diff options
| author | Alex Lam S.L <alexlamsl@gmail.com> | 2017-03-19 11:59:42 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-03-19 11:59:42 +0800 |
| commit | 96f8befdd7dbc3be9f5991f805ad8d60dfb3e6d6 (patch) | |
| tree | e0e9f00e92a5aac39b088287f791c1476287c95e /test | |
| parent | cd58635dcc8f74aafa842c2015b294ff4097ba08 (diff) | |
| download | tracifyjs-96f8befdd7dbc3be9f5991f805ad8d60dfb3e6d6.tar.gz tracifyjs-96f8befdd7dbc3be9f5991f805ad8d60dfb3e6d6.zip | |
fix commit 88fb83a (#1622)
The following is wrong:
`a == (b ? a : c)` => `b`
Because:
- `b` may not be boolean
- `a` might have side effects
- `a == a` is not always `true` (think `NaN`)
- `a == c` is not always `false`
Diffstat (limited to 'test')
| -rw-r--r-- | test/compress/conditionals.js | 96 |
1 files changed, 96 insertions, 0 deletions
diff --git a/test/compress/conditionals.js b/test/compress/conditionals.js index 074d2a65..7c81cc80 100644 --- a/test/compress/conditionals.js +++ b/test/compress/conditionals.js @@ -797,3 +797,99 @@ no_evaluate: { } } } + +equality_conditionals_false: { + options = { + conditionals: false, + sequences: true, + } + input: { + function f(a, b, c) { + console.log( + a == (b ? a : a), + a == (b ? a : c), + a != (b ? a : a), + a != (b ? a : c), + a === (b ? a : a), + a === (b ? a : c), + a !== (b ? a : a), + a !== (b ? a : c) + ); + } + f(0, 0, 0); + f(0, true, 0); + f(1, 2, 3); + f(1, null, 3); + f(NaN); + f(NaN, "foo"); + } + expect: { + function f(a, b, c) { + console.log( + a == (b ? a : a), + a == (b ? a : c), + a != (b ? a : a), + a != (b ? a : c), + a === (b ? a : a), + a === (b ? a : c), + a !== (b ? a : a), + a !== (b ? a : c) + ); + } + f(0, 0, 0), + f(0, true, 0), + f(1, 2, 3), + f(1, null, 3), + f(NaN), + f(NaN, "foo"); + } + expect_stdout: true +} + +equality_conditionals_true: { + options = { + conditionals: true, + sequences: true, + } + input: { + function f(a, b, c) { + console.log( + a == (b ? a : a), + a == (b ? a : c), + a != (b ? a : a), + a != (b ? a : c), + a === (b ? a : a), + a === (b ? a : c), + a !== (b ? a : a), + a !== (b ? a : c) + ); + } + f(0, 0, 0); + f(0, true, 0); + f(1, 2, 3); + f(1, null, 3); + f(NaN); + f(NaN, "foo"); + } + expect: { + function f(a, b, c) { + console.log( + (b, a == a), + a == (b ? a : c), + (b, a != a), + a != (b ? a : c), + (b, a === a), + a === (b ? a : c), + (b, a !== a), + a !== (b ? a : c) + ); + } + f(0, 0, 0), + f(0, true, 0), + f(1, 2, 3), + f(1, null, 3), + f(NaN), + f(NaN, "foo"); + } + expect_stdout: true +} |