From 96f8befdd7dbc3be9f5991f805ad8d60dfb3e6d6 Mon Sep 17 00:00:00 2001 From: "Alex Lam S.L" Date: Sun, 19 Mar 2017 11:59:42 +0800 Subject: fix commit 88fb83a (#1622) The following is wrong: `a == (b ? a : c)` => `b` Because: - `b` may not be boolean - `a` might have side effects - `a == a` is not always `true` (think `NaN`) - `a == c` is not always `false` --- test/compress/conditionals.js | 96 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 96 insertions(+) (limited to 'test') diff --git a/test/compress/conditionals.js b/test/compress/conditionals.js index 074d2a65..7c81cc80 100644 --- a/test/compress/conditionals.js +++ b/test/compress/conditionals.js @@ -797,3 +797,99 @@ no_evaluate: { } } } + +equality_conditionals_false: { + options = { + conditionals: false, + sequences: true, + } + input: { + function f(a, b, c) { + console.log( + a == (b ? a : a), + a == (b ? a : c), + a != (b ? a : a), + a != (b ? a : c), + a === (b ? a : a), + a === (b ? a : c), + a !== (b ? a : a), + a !== (b ? a : c) + ); + } + f(0, 0, 0); + f(0, true, 0); + f(1, 2, 3); + f(1, null, 3); + f(NaN); + f(NaN, "foo"); + } + expect: { + function f(a, b, c) { + console.log( + a == (b ? a : a), + a == (b ? a : c), + a != (b ? a : a), + a != (b ? a : c), + a === (b ? a : a), + a === (b ? a : c), + a !== (b ? a : a), + a !== (b ? a : c) + ); + } + f(0, 0, 0), + f(0, true, 0), + f(1, 2, 3), + f(1, null, 3), + f(NaN), + f(NaN, "foo"); + } + expect_stdout: true +} + +equality_conditionals_true: { + options = { + conditionals: true, + sequences: true, + } + input: { + function f(a, b, c) { + console.log( + a == (b ? a : a), + a == (b ? a : c), + a != (b ? a : a), + a != (b ? a : c), + a === (b ? a : a), + a === (b ? a : c), + a !== (b ? a : a), + a !== (b ? a : c) + ); + } + f(0, 0, 0); + f(0, true, 0); + f(1, 2, 3); + f(1, null, 3); + f(NaN); + f(NaN, "foo"); + } + expect: { + function f(a, b, c) { + console.log( + (b, a == a), + a == (b ? a : c), + (b, a != a), + a != (b ? a : c), + (b, a === a), + a === (b ? a : c), + (b, a !== a), + a !== (b ? a : c) + ); + } + f(0, 0, 0), + f(0, true, 0), + f(1, 2, 3), + f(1, null, 3), + f(NaN), + f(NaN, "foo"); + } + expect_stdout: true +} -- cgit v1.2.3