diff options
| author | Alex Lam S.L <alexlamsl@gmail.com> | 2017-03-24 18:52:48 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-03-24 18:52:48 +0800 |
| commit | 0432a7abb98f3aec871daa88331aa9223979dde3 (patch) | |
| tree | 48b15e34a50aa13c1138a083457f3842ffa3f078 /lib/compress.js | |
| parent | f3a1694a4182e1a26d3dd63dd21fcd4b38dafe3a (diff) | |
| download | tracifyjs-0432a7abb98f3aec871daa88331aa9223979dde3.tar.gz tracifyjs-0432a7abb98f3aec871daa88331aa9223979dde3.zip | |
fix assignment extraction from conditional (#1651)
fixes #1645
fixes #1646
Diffstat (limited to 'lib/compress.js')
| -rw-r--r-- | lib/compress.js | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/lib/compress.js b/lib/compress.js index b3edb840..cbcb7b86 100644 --- a/lib/compress.js +++ b/lib/compress.js @@ -3550,19 +3550,17 @@ merge(Compressor.prototype, { } var consequent = self.consequent; var alternative = self.alternative; + // if (foo) exp = something; else exp = something_else; + // | + // v + // exp = foo ? something : something_else; if (consequent instanceof AST_Assign && alternative instanceof AST_Assign && consequent.operator == alternative.operator && consequent.left.equivalent_to(alternative.left) - && (!consequent.left.has_side_effects(compressor) - || !self.condition.has_side_effects(compressor)) - ) { - /* - * Stuff like this: - * if (foo) exp = something; else exp = something_else; - * ==> - * exp = foo ? something : something_else; - */ + && (!self.condition.has_side_effects(compressor) + || consequent.operator == "=" + && !consequent.left.has_side_effects(compressor))) { return make_node(AST_Assign, self, { operator: consequent.operator, left: consequent.left, |