diff options
| author | Alex Lam S.L <alexlamsl@gmail.com> | 2019-10-30 14:21:22 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-10-30 14:21:22 +0800 |
| commit | ec7f071272384db82dff0f8fb6629f4f6fee43a5 (patch) | |
| tree | 90db03a953fcaa6f85702951b66b6ba2a715ab6e | |
| parent | f1eb03f2c0f860a963b2f61c5f8565d8703a18cb (diff) | |
| download | tracifyjs-ec7f071272384db82dff0f8fb6629f4f6fee43a5.tar.gz tracifyjs-ec7f071272384db82dff0f8fb6629f4f6fee43a5.zip | |
fix corner case in `dead_code` (#3553)
fixes #3552
| -rw-r--r-- | lib/compress.js | 20 | ||||
| -rw-r--r-- | test/compress/dead-code.js | 22 |
2 files changed, 33 insertions, 9 deletions
diff --git a/lib/compress.js b/lib/compress.js index 33943ff0..a28c7a6c 100644 --- a/lib/compress.js +++ b/lib/compress.js @@ -6433,15 +6433,17 @@ merge(Compressor.prototype, { OPT(AST_Assign, function(self, compressor) { if (compressor.option("dead_code")) { if (self.left instanceof AST_PropAccess) { - var exp = self.left.expression; - if (exp instanceof AST_Lambda - || !compressor.has_directive("use strict") - && exp instanceof AST_Constant - && !exp.may_throw_on_access(compressor)) { - return self.left instanceof AST_Dot ? self.right : make_sequence(self, [ - self.left.property, - self.right - ]).optimize(compressor); + if (self.operator == "=") { + var exp = self.left.expression; + if (exp instanceof AST_Lambda + || !compressor.has_directive("use strict") + && exp instanceof AST_Constant + && !exp.may_throw_on_access(compressor)) { + return self.left instanceof AST_Dot ? self.right : make_sequence(self, [ + self.left.property, + self.right + ]).optimize(compressor); + } } } else if (self.left instanceof AST_SymbolRef) { var def = self.left.definition(); diff --git a/test/compress/dead-code.js b/test/compress/dead-code.js index 501d55ec..93fc9f41 100644 --- a/test/compress/dead-code.js +++ b/test/compress/dead-code.js @@ -1042,3 +1042,25 @@ function_assign: { } expect_stdout: "PASS" } + +issue_3552: { + options = { + dead_code: true, + pure_getters: "strict", + } + input: { + var a = "PASS"; + (function() { + (1..p += 42) && (a = "FAIL"); + })(); + console.log(a); + } + expect: { + var a = "PASS"; + (function() { + (1..p += 42) && (a = "FAIL"); + })(); + console.log(a); + } + expect_stdout: "PASS" +} |