aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlex Lam S.L <alexlamsl@gmail.com>2017-04-23 01:51:56 +0800
committerGitHub <noreply@github.com>2017-04-23 01:51:56 +0800
commit45ce3694807ee0daeb7e0f84c12ffbd8ca4f733c (patch)
tree7acd82d0f499a80dd2f75e3291c4abf13aed8c34
parentca32a09032b3e7d6aac1f0b01f67a0b67b3037f1 (diff)
downloadtracifyjs-45ce3694807ee0daeb7e0f84c12ffbd8ca4f733c.tar.gz
tracifyjs-45ce3694807ee0daeb7e0f84c12ffbd8ca4f733c.zip
fix `AST_For.init` patch-up in `drop_unused()` (#1839)
fixes #1838
-rw-r--r--lib/compress.js3
-rw-r--r--test/compress/drop-unused.js22
2 files changed, 25 insertions, 0 deletions
diff --git a/lib/compress.js b/lib/compress.js
index 22e012e9..5a8f23bf 100644
--- a/lib/compress.js
+++ b/lib/compress.js
@@ -2066,6 +2066,7 @@ merge(Compressor.prototype, {
// certain combination of unused name + side effect leads to:
// https://github.com/mishoo/UglifyJS2/issues/44
// https://github.com/mishoo/UglifyJS2/issues/1830
+ // https://github.com/mishoo/UglifyJS2/issues/1838
// that's an invalid AST.
// We fix it at this stage by moving the `var` outside the `for`.
if (node instanceof AST_For) {
@@ -2075,6 +2076,8 @@ merge(Compressor.prototype, {
node.init = block.body.pop();
block.body.push(node);
return in_list ? MAP.splice(block.body) : block;
+ } else if (node.init instanceof AST_SimpleStatement) {
+ node.init = node.init.body;
} else if (is_empty(node.init)) {
node.init = null;
}
diff --git a/test/compress/drop-unused.js b/test/compress/drop-unused.js
index 7456f676..c702cfaf 100644
--- a/test/compress/drop-unused.js
+++ b/test/compress/drop-unused.js
@@ -1092,3 +1092,25 @@ issue_1830_2: {
}
expect_stdout: "1"
}
+
+issue_1838: {
+ options = {
+ join_vars: true,
+ loops: true,
+ unused: true,
+ }
+ beautify = {
+ beautify: true,
+ }
+ input: {
+ function f() {
+ var b = a;
+ while (c);
+ }
+ }
+ expect_exact: [
+ "function f() {",
+ " for (a; c; ) ;",
+ "}",
+ ]
+}