From 6fb9d1d2bee806abb2f67cee05a8573450a017df Mon Sep 17 00:00:00 2001
From: Steve Fink <sfink@mozilla.com>
Date: Mon, 12 Jan 2015 14:19:27 -0800
Subject: [PATCH] Bug 1137326 - Fix out of bounds error in
 JS_iterateCompartments. r=terrence, a=abillings

---
 js/src/gc/Zone.h | 11 ++++++-----
 js/src/jsapi.h   |  5 +++--
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/js/src/gc/Zone.h b/js/src/gc/Zone.h
index cbbde6b..612defe 100644
--- a/js/src/gc/Zone.h
+++ b/js/src/gc/Zone.h
@@ -389,21 +389,22 @@ struct CompartmentsInZoneIter
     // This is for the benefit of CompartmentsIterT::comp.
     friend class mozilla::Maybe<CompartmentsInZoneIter>;
   private:
-    JSCompartment **it, **end;
+    JS::Zone *zone;
+    JSCompartment **it;
 
     CompartmentsInZoneIter()
-      : it(nullptr), end(nullptr)
+      : zone(nullptr), it(nullptr)
     {}
 
   public:
-    explicit CompartmentsInZoneIter(JS::Zone *zone) {
+    explicit CompartmentsInZoneIter(JS::Zone *zone) : zone(zone) {
         it = zone->compartments.begin();
-        end = zone->compartments.end();
     }
 
     bool done() const {
         JS_ASSERT(it);
-        return it == end;
+        return it < zone->compartments.begin() ||
+               it >= zone->compartments.end();
     }
     void next() {
         JS_ASSERT(!done());
diff --git a/js/src/jsapi.h b/js/src/jsapi.h
index 5ae1f86..40fdb37 100644
--- a/js/src/jsapi.h
+++ b/js/src/jsapi.h
@@ -1780,9 +1780,10 @@ JS_LeaveCompartment(JSContext *cx, JSCompartment *oldCompartment);
 typedef void (*JSIterateCompartmentCallback)(JSRuntime *rt, void *data, JSCompartment *compartment);
 
 /*
- * This function calls |compartmentCallback| on every compartment.  Beware that
+ * This function calls |compartmentCallback| on every compartment. Beware that
  * there is no guarantee that the compartment will survive after the callback
- * returns.
+ * returns. Also, if the callback can GC, there is no guarantee that every
+ * compartment will be visited.
  */
 extern JS_PUBLIC_API(void)
 JS_IterateCompartments(JSRuntime *rt, void *data,
-- 
2.2.1

ix/log/?id=2c059863483b698c4f6f50a2ce4daaef5f1de83f'>root</a>/<a href='/guix/log/gnu?id=2c059863483b698c4f6f50a2ce4daaef5f1de83f'>gnu</a>/<a href='/guix/log/gnu/packages?id=2c059863483b698c4f6f50a2ce4daaef5f1de83f'>packages</a>/<a href='/guix/log/gnu/packages/haskell-check.scm?id=2c059863483b698c4f6f50a2ce4daaef5f1de83f'>haskell-check.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/packages/haskell-check.scm?id=2c059863483b698c4f6f50a2ce4daaef5f1de83f&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2023-07-07 15:30:21 +0200'>2023-07-07</span></td><td><a href='/guix/commit/gnu/packages/haskell-check.scm?id=549654ab5679e45e8bed4eac500c719199348da8'>gnu: Add ghc-proctest.</a></td><td>zamfofex</td></tr>
<tr><td><span title='2023-05-13 09:34:35 +0200'>2023-05-13</span></td><td><a href='/guix/commit/gnu/packages/haskell-check.scm?id=cf89a215cec346bc4d6622cbe353c058452b29b2'>gnu: ghc-tasty: Add missing dependency on i686-linux.</a></td><td>Lars-Dominik Braun</td></tr>
<tr><td><span title='2023-02-26 10:26:15 +0100'>2023-02-26</span></td><td><a href='/guix/commit/gnu/packages/haskell-check.scm?id=4bb40b098d81e70ebaf86250cb0162bb285ef6ca'>build-system: haskell: Drop default "static" output.</a></td><td>Lars-Dominik Braun</td></tr>
<tr><td><span title='2023-02-26 10:26:07 +0100'>2023-02-26</span></td><td><a href='/guix/commit/gnu/packages/haskell-check.scm?id=49a320aaa6fb4c20d6b30c56c35a8c7ffceed822'>Upgrade Haskell packages.</a></td><td>Lars-Dominik Braun</td></tr>
<tr><td><span title='2023-02-26 10:20:14 +0100'>2023-02-26</span></td><td><a href='/guix/commit/gnu/packages/haskell-check.scm?id=890a181ed1766b433b5bfe1a3419b50ffa6503cb'>gnu: Use HACKAGE-URI for packages from Hackage.</a></td><td>Lars-Dominik Braun</td></tr>
<tr><td><span title='2023-02-26 10:20:11 +0100'>2023-02-26</span></td><td><a href='/guix/commit/gnu/packages/haskell-check.scm?id=cad6aa8082e99fe60570e3fd53a0e5876a8f243e'>gnu: Add upstream-name property to Haskell packages.</a></td><td>Lars-Dominik Braun</td></tr>
<tr><td><span title='2023-02-19 01:00:01 +0100'>2023-02-19</span></td><td><a href='/guix/commit/gnu/packages/haskell-check.scm?id=1e6ddceb8318d413745ca1c9d91fde01b1e0364b'>gnu: Use HTTPS package home pages wherever possible.</a></td><td>Tobias Geerinckx-Rice</td></tr>
<tr><td><span title='2022-10-31 18:13:48 -0700'>2022-10-31</span></td><td><a href='/guix/commit/gnu/packages/haskell-check.scm?id=15ff5eebb6109159a9ea4afd8cc942d9e0113148'>gnu: Fix various lint issues in synopsis and descriptions.</a></td><td>Vagrant Cascadian</td></tr>