aboutsummaryrefslogtreecommitdiff
path: root/gnu
diff options
context:
space:
mode:
authorAlexey Abramov <levenson@mmer.org>2021-01-30 09:19:32 +0100
committer宋文武 <iyzsong@member.fsf.org>2021-02-11 11:11:39 +0800
commit408f0b4c4dba671b648fe99cd4ef77d26e4486a4 (patch)
treeabb75f99691f0e81c28ae63b35cb82d418dbab41 /gnu
parent07143d9fe11151b884901186bace1b3ec65d9f40 (diff)
downloadguix-408f0b4c4dba671b648fe99cd4ef77d26e4486a4.tar.gz
guix-408f0b4c4dba671b648fe99cd4ef77d26e4486a4.zip
services: knot: Fix configuration verification.
* gnu/services/dns.scm (verify-knot-key-configuration): Fix the order of memq arguments. (verify-knot-keystore-configuration): Likewise. (verify-knot-acl-configuration): Replace fold with every procedure. Signed-off-by: 宋文武 <iyzsong@member.fsf.org>
Diffstat (limited to 'gnu')
-rw-r--r--gnu/services/dns.scm14
1 files changed, 7 insertions, 7 deletions
diff --git a/gnu/services/dns.scm b/gnu/services/dns.scm
index b339eb0619..d4aefe6285 100644
--- a/gnu/services/dns.scm
+++ b/gnu/services/dns.scm
@@ -256,9 +256,9 @@
(let ((id (knot-key-configuration-id key)))
(unless (and (string? id) (not (equal? id "")))
(error-out "key id must be a non empty string.")))
- (unless (memq '(#f hmac-md5 hmac-sha1 hmac-sha224 hmac-sha256 hmac-sha384 hmac-sha512)
- (knot-key-configuration-algorithm key))
- (error-out "algorithm must be one of: #f, 'hmac-md5, 'hmac-sha1,
+ (unless (memq (knot-key-configuration-algorithm key)
+ '(#f hmac-md5 hmac-sha1 hmac-sha224 hmac-sha256 hmac-sha384 hmac-sha512))
+ (error-out "algorithm must be one of: #f, 'hmac-md5, 'hmac-sha1,
'hmac-sha224, 'hmac-sha256, 'hmac-sha384 or 'hmac-sha512")))
(define (verify-knot-keystore-configuration keystore)
@@ -267,9 +267,9 @@
(let ((id (knot-keystore-configuration-id keystore)))
(unless (and (string? id) (not (equal? id "")))
(error-out "keystore id must be a non empty string.")))
- (unless (memq '(pem pkcs11)
- (knot-keystore-configuration-backend keystore))
- (error-out "backend must be one of: 'pem or 'pkcs11")))
+ (unless (memq (knot-keystore-configuration-backend keystore)
+ '(pem pkcs11))
+ (error-out "backend must be one of: 'pem or 'pkcs11")))
(define (verify-knot-policy-configuration policy)
(unless (knot-policy-configuration? policy)
@@ -288,7 +288,7 @@
(unless (and (string? id) (not (equal? id "")))
(error-out "acl id must be a non empty string."))
(unless (and (list? address)
- (fold (lambda (x1 x2) (and (string? x1) (string? x2))) "" address))
+ (every string? address))
(error-out "acl address must be a list of strings.")))
(unless (boolean? (knot-acl-configuration-deny? acl))
(error-out "deny? must be #t or #f.")))