diff options
author | Ludovic Courtès <ludo@gnu.org> | 2020-03-22 12:41:28 +0100 |
---|---|---|
committer | Ludovic Courtès <ludo@gnu.org> | 2020-03-22 12:42:52 +0100 |
commit | 66a198c8075f02d7075a555b48dd3adde88ebbbf (patch) | |
tree | 95a7372ccd3bbe055adb3c4164b57111443889dd /build-aux/hydra | |
parent | 91601790d00bbfcdc943b974779cb3d153341ef6 (diff) | |
download | guix-66a198c8075f02d7075a555b48dd3adde88ebbbf.tar.gz guix-66a198c8075f02d7075a555b48dd3adde88ebbbf.zip |
hydra: evaluate: Use 'with-build-handler'.
* build-aux/hydra/evaluate.scm (command-line): Remove 'set!' for
'build-things'. Use 'with-build-handler' instead.
* build-aux/hydra/gnu-system.scm (hydra-jobs): Add comment about
removing 'show-what-to-build' call.
Diffstat (limited to 'build-aux/hydra')
-rw-r--r-- | build-aux/hydra/evaluate.scm | 78 | ||||
-rw-r--r-- | build-aux/hydra/gnu-system.scm | 2 |
2 files changed, 38 insertions, 42 deletions
diff --git a/build-aux/hydra/evaluate.scm b/build-aux/hydra/evaluate.scm index adb14808fa..6e63a149bd 100644 --- a/build-aux/hydra/evaluate.scm +++ b/build-aux/hydra/evaluate.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2016, 2017, 2018 Ludovic Courtès <ludo@gnu.org> +;;; Copyright © 2016, 2017, 2018, 2020 Ludovic Courtès <ludo@gnu.org> ;;; Copyright © 2017 Jan Nieuwenhuizen <janneke@gnu.org> ;;; ;;; This file is part of GNU Guix. @@ -24,6 +24,7 @@ (use-modules (guix store) (guix git-download) ((guix build utils) #:select (with-directory-excursion)) + ((guix ui) #:select (build-notifier)) (srfi srfi-19) (ice-9 match) (ice-9 pretty-print) @@ -89,49 +90,42 @@ Otherwise return THING." #:use-substitutes? #f #:substitute-urls '()) - ;; Grafts can trigger early builds. We do not want that to happen - ;; during evaluation, so use a sledgehammer to catch such problems. - ;; An exception, though, is the evaluation of Guix itself, which - ;; requires building a "trampoline" program. - (set! build-things - (lambda (store . args) - (format (current-error-port) - "warning: building things during evaluation~%") - (format (current-error-port) - "'build-things' arguments: ~s~%" args) - (apply real-build-things store args))) + ;; The evaluation of Guix itself requires building a "trampoline" + ;; program, and possibly everything it depends on. Thus, allow builds + ;; but print a notification. + (with-build-handler (build-notifier #:use-substitutes? #f) - ;; Add %TOP-SRCDIR to the store with a proper Git predicate so we work - ;; from a clean checkout - (let ((source (add-to-store store "guix-source" #t - "sha256" %top-srcdir - #:select? (git-predicate %top-srcdir)))) - (with-directory-excursion source - (save-module-excursion - (lambda () - (set-current-module %user-module) - (format (current-error-port) - "loading '~a' relative to '~a'...~%" - file source) - (primitive-load file)))) + ;; Add %TOP-SRCDIR to the store with a proper Git predicate so we work + ;; from a clean checkout + (let ((source (add-to-store store "guix-source" #t + "sha256" %top-srcdir + #:select? (git-predicate %top-srcdir)))) + (with-directory-excursion source + (save-module-excursion + (lambda () + (set-current-module %user-module) + (format (current-error-port) + "loading '~a' relative to '~a'...~%" + file source) + (primitive-load file)))) - ;; Call the entry point of FILE and print the resulting job sexp. - (pretty-print - (match ((module-ref %user-module - (if (equal? cuirass? "cuirass") - 'cuirass-jobs - 'hydra-jobs)) - store `((guix - . ((file-name . ,source))))) - (((names . thunks) ...) - (map (lambda (job thunk) - (format (current-error-port) "evaluating '~a'... " job) - (force-output (current-error-port)) - (cons job - (assert-valid-job job - (call-with-time-display thunk)))) - names thunks))) - port))))) + ;; Call the entry point of FILE and print the resulting job sexp. + (pretty-print + (match ((module-ref %user-module + (if (equal? cuirass? "cuirass") + 'cuirass-jobs + 'hydra-jobs)) + store `((guix + . ((file-name . ,source))))) + (((names . thunks) ...) + (map (lambda (job thunk) + (format (current-error-port) "evaluating '~a'... " job) + (force-output (current-error-port)) + (cons job + (assert-valid-job job + (call-with-time-display thunk)))) + names thunks))) + port)))))) ((command _ ...) (format (current-error-port) "Usage: ~a FILE [cuirass] Evaluate the Hydra or Cuirass jobs defined in FILE.~%" diff --git a/build-aux/hydra/gnu-system.scm b/build-aux/hydra/gnu-system.scm index 4afdb48903..a03324daeb 100644 --- a/build-aux/hydra/gnu-system.scm +++ b/build-aux/hydra/gnu-system.scm @@ -65,6 +65,8 @@ Return #f if no such checkout is found." (run-with-store store (channel-instances->derivation (list instance)))) + ;; TODO: Remove 'show-what-to-build' call when Cuirass' 'evaluate' scripts + ;; uses 'with-build-handler'. (show-what-to-build store (list derivation)) (build-derivations store (list derivation)) |