diff options
| author | Ludovic Courtès <ludo@gnu.org> | 2023-10-28 15:29:01 +0200 |
|---|---|---|
| committer | Ludovic Courtès <ludo@gnu.org> | 2023-11-05 23:23:23 +0100 |
| commit | ab13e2be6939340a9dd8ba815e3518be41b19747 (patch) | |
| tree | e216f6f38a9dfd48a388d952813854e0d9a1c34f /ROADMAP | |
| parent | 9f05fbb67d0de4d577c21a6fb6888cb6be67cd12 (diff) | |
| download | guix-ab13e2be6939340a9dd8ba815e3518be41b19747.tar.gz guix-ab13e2be6939340a9dd8ba815e3518be41b19747.zip | |
time-machine: Make target commit check cheaper.
Commit 79ec651a286c71a3d4c72be33a1f80e76a560031 introduced a check to
error out when attempting to use ‘time-machine’ to travel to a commit
before ‘v1.0.0’.
This commit fixes a performance issue with the strategy used in
79ec651a286c71a3d4c72be33a1f80e76a560031 (the repository was opened,
updated, and traversed a second time by ‘validate-guix-channel’) as well
as a user interface issue (“Updating channel” messages would be printed
too late).
This patch reimplements the check in terms of the existing #:validate-pull
mechanism, which is designed to avoid extra repository operations.
Fixes <https://issues.guix.gnu.org/65788>.
* guix/inferior.scm (cached-channel-instance): Change default value
of #:validate-channels. Remove call to VALIDATE-CHANNELS; pass it
as #:validate-pull to ‘latest-channel-instances’.
* guix/scripts/time-machine.scm (%reference-channels): New variable.
(validate-guix-channel): New procedure, written as a simplification of…
(guix-time-machine)[validate-guix-channel]: … this. Remove.
Pass #:reference-channels to ‘cached-channel-instance’.
Reported-by: Simon Tournier <zimon.toutoune@gmail.com>
Change-Id: I9b0ec61fba7354fe08b04a91f4bd32b72a35460c
Diffstat (limited to 'ROADMAP')
0 files changed, 0 insertions, 0 deletions