aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLiliana Marie Prikler <liliana.prikler@gmail.com>2024-12-08 18:30:54 +0100
committerLiliana Marie Prikler <liliana.prikler@gmail.com>2025-01-19 13:06:08 +0100
commit8f799ca8cee42a7be289022489d6ec08e329dac5 (patch)
tree13458fa441455021e30151faafafc61660403bee
parent71db233a7d2b5a25ece95853616f4c63a8158175 (diff)
downloadguix-8f799ca8cee42a7be289022489d6ec08e329dac5.tar.gz
guix-8f799ca8cee42a7be289022489d6ec08e329dac5.zip
gnu: emacs: Pin natively compiled packages.
* gnu/packages/patches/emacs-native-comp-pin-packages.patch: New patch. * gnu/local.mk (dist_patch_DATA): Register it here. * gnu/packages/emacs.scm (emacs)[source]: Use it here. [#:phases]: Remove ‘disable-native-compilation’. Fixes: Emacs native-comp collisions <https://issues.guix.gnu.org/67292>
-rw-r--r--gnu/local.mk1
-rw-r--r--gnu/packages/emacs.scm11
-rw-r--r--gnu/packages/patches/emacs-native-comp-pin-packages.patch39
3 files changed, 41 insertions, 10 deletions
diff --git a/gnu/local.mk b/gnu/local.mk
index 342beca9f6..3d84972e1a 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1216,6 +1216,7 @@ dist_patch_DATA = \
%D%/packages/patches/emacs-lispy-fix-thread-last-test.patch \
%D%/packages/patches/emacs-native-comp-driver-options.patch \
%D%/packages/patches/emacs-native-comp-fix-filenames.patch \
+ %D%/packages/patches/emacs-native-comp-pin-packages.patch \
%D%/packages/patches/emacs-next-exec-path.patch \
%D%/packages/patches/emacs-next-native-comp-driver-options.patch \
%D%/packages/patches/emacs-pasp-mode-quote-file-names.patch \
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index c5b57211dd..a24242d5d7 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -117,6 +117,7 @@
"emacs-fix-scheme-indent-function.patch"
"emacs-native-comp-driver-options.patch"
"emacs-native-comp-fix-filenames.patch"
+ "emacs-native-comp-pin-packages.patch"
"emacs-pgtk-super-key-fix.patch"))
(modules '((guix build utils)))
(snippet
@@ -233,16 +234,6 @@
(("\\(tramp-compat-process-running-p \"(.*)\"\\)" all process)
(format #f "(or ~a (tramp-compat-process-running-p ~s))"
all (string-append "." process "-real"))))))
- (add-after 'unpack 'disable-native-compilation
- (lambda _
- ;; Temporary workaround to prevent the behaviour discussed in
- ;; <https://issues.guix.gnu.org/72333>.
- ;; Please remove once the native-compilation for Emacs packages
- ;; is fully supported.
- (substitute* "lisp/transient.el"
- ((";; End:")
- ";; no-native-compile: t
-;; End:"))))
(add-before 'configure 'fix-/bin/pwd
(lambda _
;; Use `pwd', not `/bin/pwd'.
diff --git a/gnu/packages/patches/emacs-native-comp-pin-packages.patch b/gnu/packages/patches/emacs-native-comp-pin-packages.patch
new file mode 100644
index 0000000000..dc328f03a8
--- /dev/null
+++ b/gnu/packages/patches/emacs-native-comp-pin-packages.patch
@@ -0,0 +1,39 @@
+Index: emacs-29.4/src/lread.c
+===================================================================
+--- emacs-29.4.orig/src/lread.c
++++ emacs-29.4/src/lread.c
+@@ -1668,9 +1668,34 @@ directories, make sure the PREDICATE fun
+
+ #ifdef HAVE_NATIVE_COMP
+ static bool
++permit_swap_for_eln (Lisp_Object src_name, Lisp_Object eln_name)
++{
++ char *src = SSDATA (src_name), *eln = SSDATA (eln_name);
++ size_t eln_ln = strlen (eln);
++
++ while (*src && *eln && *src == *eln)
++ {
++ ++src; ++eln; --eln_ln;
++ }
++
++ /* After stripping common prefixes, the first directory should be
++ * "lib/" (inside the Guix store) or "native-lisp" (inside Emacs build).
++ * Alternatively, if eln contains "eln-cache", it's likely the user's
++ * cache, which we will also permit. */
++
++ return
++ (eln_ln > 4 && !strncmp (eln, "lib/", 4)) ||
++ (eln_ln > 12 && !strncmp (eln, "native-lisp/", 12)) ||
++ strstr (eln, "eln-cache") != NULL;
++}
++
++static bool
+ maybe_swap_for_eln1 (Lisp_Object src_name, Lisp_Object eln_name,
+ Lisp_Object *filename, int *fd, struct timespec mtime)
+ {
++ if (!permit_swap_for_eln (src_name, eln_name))
++ return false;
++
+ struct stat eln_st;
+ int eln_fd = emacs_open (SSDATA (ENCODE_FILE (eln_name)), O_RDONLY, 0);
+