From 9d3b1efd86d659c6519cc74b7f8b232e07e0675e Mon Sep 17 00:00:00 2001 From: "Alex Lam S.L" Date: Thu, 30 May 2019 05:01:53 +0800 Subject: fix corner case in `assignments` (#3430) fixes #3429 --- lib/compress.js | 2 +- test/compress/assignment.js | 46 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 47 insertions(+), 1 deletion(-) diff --git a/lib/compress.js b/lib/compress.js index 7bbb5a20..09d416cf 100644 --- a/lib/compress.js +++ b/lib/compress.js @@ -3856,7 +3856,7 @@ merge(Compressor.prototype, { if (!(rhs instanceof AST_Binary && lazy_op[rhs.operator])) return rhs; var sym = assign.left; if (!(sym instanceof AST_SymbolRef) || sym.name != rhs.left.name) return rhs; - return rhs.right; + return rhs.right.has_side_effects(compressor) ? rhs : rhs.right; } function scan_ref_scoped(node, descend) { diff --git a/test/compress/assignment.js b/test/compress/assignment.js index ecd0ac4a..5ca7440a 100644 --- a/test/compress/assignment.js +++ b/test/compress/assignment.js @@ -327,3 +327,49 @@ issue_3427: { } expect: {} } + +issue_3429_1: { + options = { + assignments: true, + side_effects: true, + unused: true, + } + input: { + var a = "PASS"; + (function(b) { + b && (b = a = "FAIL"); + })(); + console.log(a); + } + expect: { + var a = "PASS"; + (function(b) { + b = b && (a = "FAIL"); + })(); + console.log(a); + } + expect_stdout: "PASS" +} + +issue_3429_2: { + options = { + assignments: true, + side_effects: true, + unused: true, + } + input: { + var a; + (function(b) { + b || (b = a = "FAIL"); + })(42); + console.log(a); + } + expect: { + var a; + (function(b) { + b = b || (a = "FAIL"); + })(42); + console.log(a); + } + expect_stdout: "undefined" +} -- cgit v1.2.3