aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlex Lam S.L <alexlamsl@gmail.com>2019-03-14 16:05:56 +0800
committerGitHub <noreply@github.com>2019-03-14 16:05:56 +0800
commitebd82b3fb6773f1985752550254a2effcc70b4af (patch)
tree59eb185aa9083de6699f49e4d37b23411d4d08c7
parentd074aa6e27de77bc60e69b933f90725931c8d5df (diff)
downloadtracifyjs-ebd82b3fb6773f1985752550254a2effcc70b4af.tar.gz
tracifyjs-ebd82b3fb6773f1985752550254a2effcc70b4af.zip
fix corner case in `collapse_vars` (#3334)
fixes #3274
-rw-r--r--lib/compress.js18
-rw-r--r--test/compress/functions.js30
2 files changed, 42 insertions, 6 deletions
diff --git a/lib/compress.js b/lib/compress.js
index 2ccf330d..04adb8b2 100644
--- a/lib/compress.js
+++ b/lib/compress.js
@@ -1585,13 +1585,19 @@ merge(Compressor.prototype, {
var found = false;
return statements[stat_index].transform(new TreeTransformer(function(node, descend, in_list) {
if (found) return node;
- if (node === expr || node.body === expr) {
+ if (node !== expr && node.body !== expr) return;
+ if (node instanceof AST_VarDef) {
found = true;
- if (node instanceof AST_VarDef) {
- node.value = null;
- return node;
- }
- return in_list ? MAP.skip : null;
+ node.value = null;
+ return node;
+ }
+ if (in_list) {
+ found = true;
+ return MAP.skip;
+ }
+ if (!this.parent()) {
+ found = true;
+ return null;
}
}, function(node) {
if (node instanceof AST_Sequence) switch (node.expressions.length) {
diff --git a/test/compress/functions.js b/test/compress/functions.js
index 96689eae..96a58aa6 100644
--- a/test/compress/functions.js
+++ b/test/compress/functions.js
@@ -2315,3 +2315,33 @@ issue_3125: {
}
expect_stdout: "PASS"
}
+
+issue_3274: {
+ options = {
+ collapse_vars: true,
+ inline: true,
+ join_vars: true,
+ loops: true,
+ reduce_vars: true,
+ unused: true,
+ }
+ input: {
+ (function() {
+ var g = function(a) {
+ var c = a.p, b = c;
+ return b != c;
+ };
+ while (g(1))
+ console.log("FAIL");
+ console.log("PASS");
+ })();
+ }
+ expect: {
+ (function() {
+ for (var c; void 0, (c = 1..p) != c;)
+ console.log("FAIL");
+ console.log("PASS");
+ })();
+ }
+ expect_stdout: "PASS"
+}