aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlex Lam S.L <alexlamsl@gmail.com>2018-05-26 05:45:44 +0800
committerGitHub <noreply@github.com>2018-05-26 05:45:44 +0800
commitefa21ae3e6c7399913f98cc01f8888bf6158ae49 (patch)
treef5956d15659212d63cbee8b6bbc851cc0f82b851
parent24d9633a355ff0fac64dee2b356b99661079e921 (diff)
downloadtracifyjs-efa21ae3e6c7399913f98cc01f8888bf6158ae49.tar.gz
tracifyjs-efa21ae3e6c7399913f98cc01f8888bf6158ae49.zip
fix corner case in `reduce_vars` (#3151)
-rw-r--r--lib/compress.js3
-rw-r--r--test/compress/reduce_vars.js36
2 files changed, 37 insertions, 2 deletions
diff --git a/lib/compress.js b/lib/compress.js
index ebb2d408..1832f7a8 100644
--- a/lib/compress.js
+++ b/lib/compress.js
@@ -388,7 +388,6 @@ merge(Compressor.prototype, {
tw.defun_ids[def.id] = false;
}
});
- return true;
};
}
@@ -565,7 +564,7 @@ merge(Compressor.prototype, {
return true;
});
def(AST_Call, function(tw, descend) {
- if (tw.find_parent(AST_Scope).may_call_this()) return;
+ tw.find_parent(AST_Scope).may_call_this();
var exp = this.expression;
if (!(exp instanceof AST_SymbolRef)) return;
var def = exp.definition();
diff --git a/test/compress/reduce_vars.js b/test/compress/reduce_vars.js
index 626893f4..0af80da5 100644
--- a/test/compress/reduce_vars.js
+++ b/test/compress/reduce_vars.js
@@ -6367,3 +6367,39 @@ issue_3140_4: {
}
expect_stdout: "PASS"
}
+
+issue_3140_5: {
+ options = {
+ evaluate: true,
+ reduce_vars: true,
+ }
+ input: {
+ var n = 1, c = 0;
+ (function(a) {
+ var b = function() {
+ this;
+ n-- && h();
+ }();
+ function h() {
+ b && c++;
+ }
+ h(b = 1);
+ })();
+ console.log(c);
+ }
+ expect: {
+ var n = 1, c = 0;
+ (function(a) {
+ var b = function() {
+ this;
+ n-- && h();
+ }();
+ function h() {
+ b && c++;
+ }
+ h(b = 1);
+ })();
+ console.log(c);
+ }
+ expect_stdout: "1"
+}