diff options
author | Alex Lam S.L <alexlamsl@gmail.com> | 2021-05-28 03:53:10 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-05-28 10:53:10 +0800 |
commit | d320a6cde2ef6436874f4f3790c790d65ed0c966 (patch) | |
tree | e23d8cfd36a8fa57c0ee196d622eea9adc1d121f | |
parent | 8cd95dd2635189b27d1956796d917549e2179bf5 (diff) | |
download | tracifyjs-d320a6cde2ef6436874f4f3790c790d65ed0c966.tar.gz tracifyjs-d320a6cde2ef6436874f4f3790c790d65ed0c966.zip |
fix corner case in `awaits` (#4973)
fixes #4972
-rw-r--r-- | lib/compress.js | 11 | ||||
-rw-r--r-- | test/compress/awaits.js | 108 |
2 files changed, 118 insertions, 1 deletions
diff --git a/lib/compress.js b/lib/compress.js index 4c85c51b..872cd1cb 100644 --- a/lib/compress.js +++ b/lib/compress.js @@ -9898,7 +9898,16 @@ merge(Compressor.prototype, { if (is_arrow(parent)) { if (parent.value === node) return exp.optimize(compressor); } else if (parent instanceof AST_Return) { - return exp.optimize(compressor); + var drop = true; + do { + node = parent; + parent = compressor.parent(level++); + if (parent instanceof AST_Try && parent.bfinally && parent.bfinally !== node) { + drop = false; + break; + } + } while (parent && !(parent instanceof AST_Scope)); + if (drop) return exp.optimize(compressor); } else if (parent instanceof AST_Sequence) { if (parent.tail_node() === node) continue; } diff --git a/test/compress/awaits.js b/test/compress/awaits.js index d5b60789..e1b2805c 100644 --- a/test/compress/awaits.js +++ b/test/compress/awaits.js @@ -1574,3 +1574,111 @@ issue_4764_3: { expect_stdout: "PASS" node_version: ">=8" } + +issue_4972_1: { + options = { + awaits: true, + side_effects: true, + } + input: { + console.log("foo"); + (async function() { + try { + return await "bar"; + } finally { + console.log("baz"); + } + })().then(console.log); + console.log("moo"); + } + expect: { + console.log("foo"); + (async function() { + try { + return await "bar"; + } finally { + console.log("baz"); + } + })().then(console.log); + console.log("moo"); + } + expect_stdout: [ + "foo", + "moo", + "baz", + "bar", + ] + node_version: ">=8" +} + +issue_4972_2: { + options = { + awaits: true, + side_effects: true, + } + input: { + console.log("foo"); + (async function() { + try { + console.log("bar"); + } finally { + return await "baz"; + } + })().then(console.log); + console.log("moo"); + } + expect: { + console.log("foo"); + (async function() { + try { + console.log("bar"); + } finally { + return "baz"; + } + })().then(console.log); + console.log("moo"); + } + expect_stdout: [ + "foo", + "bar", + "moo", + "baz", + ] + node_version: ">=8" +} + +issue_4972_3: { + options = { + awaits: true, + side_effects: true, + } + input: { + console.log("foo"); + try { + (async function() { + return await "bar"; + })().then(console.log); + } finally { + console.log("baz"); + } + console.log("moo"); + } + expect: { + console.log("foo"); + try { + (async function() { + return "bar"; + })().then(console.log); + } finally { + console.log("baz"); + } + console.log("moo"); + } + expect_stdout: [ + "foo", + "baz", + "moo", + "bar", + ] + node_version: ">=8" +} |