diff options
author | Alex Lam S.L <alexlamsl@gmail.com> | 2020-08-26 10:32:20 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-08-26 17:32:20 +0800 |
commit | 93d084a1d191379a55498a12f79f573e7bb1d1be (patch) | |
tree | 799f169714a73f3f1b4aae4d10efedd7642e5e57 | |
parent | c7a3e09407fbed928ccd874609c63c31b27f052a (diff) | |
download | tracifyjs-93d084a1d191379a55498a12f79f573e7bb1d1be.tar.gz tracifyjs-93d084a1d191379a55498a12f79f573e7bb1d1be.zip |
fix corner case in `loops` & `unused` (#4076)
fixes #4075
-rw-r--r-- | lib/compress.js | 4 | ||||
-rw-r--r-- | test/compress/loops.js | 22 |
2 files changed, 25 insertions, 1 deletions
diff --git a/lib/compress.js b/lib/compress.js index 213cead3..a1f3d50c 100644 --- a/lib/compress.js +++ b/lib/compress.js @@ -4677,7 +4677,9 @@ merge(Compressor.prototype, { sym = sym.expression.tail_node(); } var def = sym.definition(); - if (!def || def.id in in_use_ids) return; + if (!def) return; + if (def.scope !== self) return; + if (def.id in in_use_ids) return; log(sym, "Dropping unused loop variable {name}"); var value = node.object.drop_side_effect_free(compressor); if (!value) return in_list ? List.skip : make_node(AST_EmptyStatement, node); diff --git a/test/compress/loops.js b/test/compress/loops.js index 4a276b9e..23d46de1 100644 --- a/test/compress/loops.js +++ b/test/compress/loops.js @@ -963,3 +963,25 @@ issue_3634_2: { } expect_stdout: "1" } + +issue_4075: { + options = { + loops: true, + unused: true, + } + input: { + var a = "FAIL"; + (function() { + for (a in { PASS: 0 }); + })() + console.log(a); + } + expect: { + var a = "FAIL"; + (function() { + for (a in { PASS: 0 }); + })() + console.log(a); + } + expect_stdout: "PASS" +} |