diff options
author | Alex Lam S.L <alexlamsl@gmail.com> | 2017-04-17 17:24:29 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-04-17 17:24:29 +0800 |
commit | 6d5f341999da7dfad708979151932fd9d8242ebd (patch) | |
tree | 733a86ed60adb6bb78a8caeed03916ad6cd7da74 | |
parent | 4ffb6fce7668a1199284e4ce8be91fdaeaf2df0e (diff) | |
download | tracifyjs-6d5f341999da7dfad708979151932fd9d8242ebd.tar.gz tracifyjs-6d5f341999da7dfad708979151932fd9d8242ebd.zip |
fix `reduce_vars` on boolean binary expressions (#1819)
Side effects of `&&` and `||` have not mattered until #1814, which takes assignment expressions into account.
-rw-r--r-- | lib/compress.js | 8 | ||||
-rw-r--r-- | test/compress/reduce_vars.js | 23 |
2 files changed, 31 insertions, 0 deletions
diff --git a/lib/compress.js b/lib/compress.js index 7324fe0e..f49dd60e 100644 --- a/lib/compress.js +++ b/lib/compress.js @@ -340,6 +340,14 @@ merge(Compressor.prototype, { }); } } + if (node instanceof AST_Binary + && (node.operator == "&&" || node.operator == "||")) { + node.left.walk(tw); + push(); + node.right.walk(tw); + pop(); + return true; + } if (node instanceof AST_If) { node.condition.walk(tw); push(); diff --git a/test/compress/reduce_vars.js b/test/compress/reduce_vars.js index 82b00211..94d37cb7 100644 --- a/test/compress/reduce_vars.js +++ b/test/compress/reduce_vars.js @@ -2217,3 +2217,26 @@ try_abort: { } expect_stdout: "1 undefined" } + +boolean_binary_assign: { + options = { + evaluate: true, + reduce_vars: true, + unused: true, + } + input: { + !function() { + var a; + void 0 && (a = 1); + console.log(a); + }(); + } + expect: { + !function() { + var a; + void 0; + console.log(a); + }(); + } + expect_stdout: "undefined" +} |