aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnthony Van de Gejuchte <anthonyvdgent@gmail.com>2016-07-21 03:19:24 +0200
committerAnthony Van de Gejuchte <anthonyvdgent@gmail.com>2016-07-21 14:42:16 +0200
commit642273c29002e7676719f489d7fcf552974118f4 (patch)
tree49b1e07d8e93449544b7f17d368303255572b81f
parente8b23c779816442a1d4e06453f06ab5a187ac98e (diff)
downloadtracifyjs-642273c29002e7676719f489d7fcf552974118f4.tar.gz
tracifyjs-642273c29002e7676719f489d7fcf552974118f4.zip
Legacy octal integer strict mode fixes
-rw-r--r--lib/parse.js5
-rw-r--r--test/mocha/number-literal.js24
-rw-r--r--test/mocha/string-literal.js2
3 files changed, 29 insertions, 2 deletions
diff --git a/lib/parse.js b/lib/parse.js
index bd6f95f6..ec82d47d 100644
--- a/lib/parse.js
+++ b/lib/parse.js
@@ -349,6 +349,9 @@ function tokenizer($TEXT, filename, html5_comments, shebang) {
return is_alphanumeric_char(code);
});
if (prefix) num = prefix + num;
+ if (RE_OCT_NUMBER.test(num) && next_token.has_directive("use strict")) {
+ parse_error("SyntaxError: Legacy octal literals are not allowed in strict mode");
+ }
var valid = parse_js_number(num);
if (!isNaN(valid)) {
return token("num", valid);
@@ -392,7 +395,7 @@ function tokenizer($TEXT, filename, html5_comments, shebang) {
// Parse
if (ch === "0") return "\0";
if (ch.length > 0 && next_token.has_directive("use strict"))
- parse_error("SyntaxError: Octal literals are not allowed in strict mode");
+ parse_error("SyntaxError: Legacy octal escape sequences are not allowed in strict mode");
return String.fromCharCode(parseInt(ch, 8));
}
diff --git a/test/mocha/number-literal.js b/test/mocha/number-literal.js
new file mode 100644
index 00000000..8e05574a
--- /dev/null
+++ b/test/mocha/number-literal.js
@@ -0,0 +1,24 @@
+var assert = require("assert");
+var uglify = require("../../");
+
+describe("Number literals", function () {
+ it("Should not allow legacy octal literals in strict mode", function() {
+ var inputs = [
+ '"use strict";00;',
+ '"use strict"; var foo = 00;'
+ ];
+
+ var test = function(input) {
+ return function() {
+ uglify.parse(input);
+ }
+ }
+ var error = function(e) {
+ return e instanceof uglify.JS_Parse_Error &&
+ e.message === "SyntaxError: Legacy octal literals are not allowed in strict mode";
+ }
+ for (var i = 0; i < inputs.length; i++) {
+ assert.throws(test(inputs[i]), error, inputs[i]);
+ }
+ });
+}); \ No newline at end of file
diff --git a/test/mocha/string-literal.js b/test/mocha/string-literal.js
index fc4c4277..eb9e6f1c 100644
--- a/test/mocha/string-literal.js
+++ b/test/mocha/string-literal.js
@@ -49,7 +49,7 @@ describe("String literals", function() {
var error = function(e) {
return e instanceof UglifyJS.JS_Parse_Error &&
- e.message === "SyntaxError: Octal literals are not allowed in strict mode";
+ e.message === "SyntaxError: Legacy octal escape sequences are not allowed in strict mode";
}
for (var input in inputs) {