diff options
| author | Elvis Pranskevichus <elvis@edgedb.com> | 2021-08-04 19:25:44 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-08-04 19:25:44 -0700 |
| commit | fa355239e70411179c70b16ed4ff7113d8008dad (patch) | |
| tree | 776efefb6e20a2ef53a903172032250f86acb5d6 /.github/workflows | |
| parent | 3f8cb24cf3da3af1b86ef61cefc091784d39ec08 (diff) | |
| download | immutables-fa355239e70411179c70b16ed4ff7113d8008dad.tar.gz immutables-fa355239e70411179c70b16ed4ff7113d8008dad.zip | |
Fix test_none_collisions on 32-bit systems (#69)
There are two issues at play here:
1. Python version of `map_hash` unnecessarily performs hash truncation
even if the hash is already 32-bit wide, which potentially converts
it from signed int to unsigned long.
2. The `test_none_collisions` test generates a collision node with
hash greater than 2^32.
Both of these are problematic on 32-bit systems, where `sizeof(Py_hash_t)`
is 4, and so anything that doesn't fit into `Py_hash_t` gets bit-mangled,
breaking the `hash(x) != x` invariance that the test relies upon.
Fixes: #53
Fixes: #50
Diffstat (limited to '.github/workflows')
| -rw-r--r-- | .github/workflows/tests.yml | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 8613b21..90bffc3 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -16,6 +16,13 @@ jobs: matrix: python-version: [3.6, 3.7, 3.8, 3.9, 3.10.0-beta.4] os: [windows-latest, ubuntu-latest, macos-latest] + arch: [x64, x86] + exclude: + # 32-bit Python is only available on Windows + - os: ubuntu-latest + arch: x86 + - os: macos-latest + arch: x86 steps: - uses: actions/checkout@v2 @@ -38,11 +45,12 @@ jobs: if: steps.release.outputs.version == 0 with: python-version: ${{ matrix.python-version }} + architecture: ${{ matrix.arch }} - name: Test if: steps.release.outputs.version == 0 run: | - pip install -e .[test] + pip install --verbose -e .[test] flake8 immutables/ tests/ mypy immutables/ python -m pytest -v |