# GNU Guix --- Functional package management for GNU
# Copyright © 2014 Cyril Roelandt <tipecaml@gmail.com>
#
# This file is part of GNU Guix.
#
# GNU Guix is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or (at
# your option) any later version.
#
# GNU Guix is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.

#
# Test the `guix lint' command-line utility.
#

guix lint --version

# Choose a module directory not below any %LOAD-PATH component.  This is
# necessary when testing '-L' with a relative file name.
module_dir="$(mktemp -d)"

mkdir -p "$module_dir"
trap "rm -rf $module_dir" EXIT


cat > "$module_dir/foo.scm"<<EOF
(define-module (foo)
  #:use-module (guix packages)
  #:use-module (gnu packages base))

(define-public dummy
  (package (inherit hello)
    (name "dummy")
    (version "42")
    (synopsis "dummy package")
    (description "dummy package. Only used for testing purposes.")))
EOF

GUIX_PACKAGE_PATH="$module_dir"
export GUIX_PACKAGE_PATH

grep_warning ()
{
    res=`echo "$1" | grep -E -c "(synopsis|description) should"`
    echo $res
}

# Three issues with the dummy package:
# 1) the synopsis starts with the package name;
# 2) the synopsis starts with a lower-case letter;
# 3) the description has a single space following the end-of-sentence period.

out=`guix lint -c synopsis,description dummy 2>&1`
test `grep_warning "$out"` -eq 3

out=`guix lint -c synopsis dummy 2>&1`
test `grep_warning "$out"` -eq 2

out=`guix lint -c description dummy 2>&1`
test `grep_warning "$out"` -eq 1

out=`guix lint -c description,synopsis dummy 2>&1`
test `grep_warning "$out"` -eq 3

guix lint -c synopsis,invalid-checker dummy 2>&1 | \
   grep -q 'invalid-checker: invalid checker'

# Make sure specifying multiple packages works.
guix lint -c inputs-should-be-native dummy dummy@42 dummy


# Use --load-path instead.
unset GUIX_PACKAGE_PATH

out=`guix lint -L $module_dir -c synopsis,description dummy 2>&1`
test `grep_warning "$out"` -eq 3

# Make sure specifying multiple packages works.
guix lint -L $module_dir -c inputs-should-be-native dummy dummy@42 dummy

# Test '-L' with a relative file name.  'guix lint' will see "t-xyz/foo.scm"
# (instead of "foo.scm") and will thus fail to find it in %LOAD-PATH.  Check
# that it does find it anyway.  See <https://bugs.gnu.org/42543>.
(cd "$module_dir"/.. ; guix lint -c formatting -L "$(basename "$module_dir")" dummy@42) 2>&1 > "$module_dir/out"
test -z "$(cat "$module_dir/out")"

# Likewise, when there's a warning, 'package-field-location' used to crash
# because it can't find "t-xyz/foo.scm".  See <https://bugs.gnu.org/46390>.
(cd "$module_dir"/.. ; guix lint -c synopsis -L "$(basename "$module_dir")" dummy@42) 2>&1 > "$module_dir/out"
grep_warning "`cat "$module_dir/out"`"
er.scm (containerized-operating-system):
Change 'guix-configuration' to add "--disable-chroot".
</span></span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2023-06-09 18:15:07 +0200'>2023-06-09</span></td><td><a href='/guix/commit/gnu/system/linux-container.scm?id=44bbfc24e4bcc48d0e3343cd3d83452721af8c36'>linux-container: Adjust to 'modify-services' semantic change.</a><span class='msg-avail'>...<span class='msg-tooltip'>This is a followup to dbbc7e946131ba257728f1d05b96c4339b7ee88b:
'nscd-service-type' isn't necessarily present in OS, so we cannot use
the 'modify-services' as it would now error out.  This was happening
with the "guix system docker-image" test in 'tests/guix-system.sh'.

* gnu/system/linux-container.scm (containerized-operating-system): Use
'filter-map' instead of 'remove' + 'modify-services'.
</span></span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2023-03-26 14:15:16 +0100'>2023-03-26</span></td><td><a href='/guix/commit/gnu/system/linux-container.scm?id=42fbe62d52a82d1003c3d7039d3c4a46806c5cee'>linux-container: Remove hosts-service-type when network is shared.</a><span class='msg-avail'>...<span class='msg-tooltip'>Fixes &lt;https://issues.guix.gnu.org/61627&gt;.

* gnu/system/linux-container.scm (container-essential-services): When
shared-network? is true, remove the hosts-service-type service kind.
</span></span></td><td>Pierre Langlois</td></tr>
<tr><td><span title='2022-12-01 19:52:13 +0100'>2022-12-01</span></td><td><a href='/guix/commit/gnu/system/linux-container.scm?id=1a63aea94340f6a24ac09e1c348401e9dfd05395'>linux-container: Do not replace nscd-service-type.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/system/linux-container.scm (containerized-operating-system): Respect
customizations to the nscd-service-type and only modify the caches field.
</span></span></td><td>Ricardo Wurmus</td></tr>
<tr><td><span title='2022-08-09 20:32:13 +0200'>2022-08-09</span></td><td><a href='/guix/commit/gnu/system/linux-container.scm?id=26af06b66b65354a46b2196d1c11c90168b7fa12'>linux-container: container-script: Parse command line options.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/system/linux-container.scm (container-script): Accept command line
options to bind mount host directories into the container.
* doc/guix.texi (Invoking guix system): Document options.
</span></span></td><td>Ricardo Wurmus</td></tr>
<tr><td><span title='2022-05-31 14:53:42 -0400'>2022-05-31</span></td><td><a href='/guix/commit/gnu/system/linux-container.scm?id=edac21bfc78ffea85f4dac7206e5e7cd621bba19'>gnu: Remove wicd.</a><span class='msg-avail'>...<span class='msg-tooltip'>The last release is from 2017, stuck on Python 2.

* gnu/packages/wicd.scm: Delete file.
* gnu/packages/patches/wicd-bitrate-none-fix.patch: Delete file.
* gnu/packages/patches/wicd-get-selected-profile-fix.patch: Likewise.
* gnu/packages/patches/wicd-urwid-1.3.patch: Likewise.
* gnu/packages/patches/wicd-wpa2-ttls.patch: Likewise.
* gnu/local.mk: De-register them.
* gnu/services/networking.scm: Remove wicd service...
* doc/guix.texi: ... and its documentation.
* gnu/system/linux-container.scm (containerized-operating-system)
&lt;services-to-drop&gt;: Remove wicd-service-type.
</span></span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2022-03-19 18:26:00 +0100'>2022-03-19</span></td><td><a href='/guix/commit/gnu/system/linux-container.scm?id=cff9fee82a06f58b10a5b3a7743295c53f7988b8'>linux-container: Add #:guest-uid and #:guest-gid to 'eval/container'.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/system/linux-container.scm (eval/container): Add #:guest-uid
and #:guest-gid and honor them.
</span></span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2022-03-19 18:26:00 +0100'>2022-03-19</span></td><td><a href='/guix/commit/gnu/system/linux-container.scm?id=c77544b387882450599b5f7e2712abdadaa074e9'>linux-container: 'eval/container' honors #:namespaces.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/system/linux-container.scm (eval/container): Pass #:namespaces to
'call-with-container'.
</span></span></td><td>Ludovic Courtès</td></tr>