# GNU Guix --- Functional package management for GNU
# Copyright © 2014 Cyril Roelandt <tipecaml@gmail.com>
#
# This file is part of GNU Guix.
#
# GNU Guix is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or (at
# your option) any later version.
#
# GNU Guix is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.

#
# Test the `guix lint' command-line utility.
#

guix lint --version

module_dir="t-guix-lint-$$"
mkdir "$module_dir"
trap "rm -rf $module_dir" EXIT


cat > "$module_dir/foo.scm"<<EOF
(define-module (foo)
  #:use-module (guix packages)
  #:use-module (gnu packages base))

(define-public dummy
  (package (inherit hello)
    (name "dummy")
    (version "42")
    (synopsis "dummy package")
    (description "dummy package. Only used for testing purposes.")))
EOF

GUIX_PACKAGE_PATH="$module_dir"
export GUIX_PACKAGE_PATH

grep_warning ()
{
    res=`echo "$1" | grep -E -c "(synopsis|description) should"`
    echo $res
}

# Three issues with the dummy package:
# 1) the synopsis starts with the package name;
# 2) the synopsis starts with a lower-case letter;
# 3) the description has a single space following the end-of-sentence period.

out=`guix lint dummy 2>&1`
if [ `grep_warning "$out"` -ne 3 ]
then false; else true; fi

out=`guix lint -c synopsis dummy 2>&1`
if [ `grep_warning "$out"` -ne 2 ]
then false; else true; fi

out=`guix lint -c description dummy 2>&1`
if [ `grep_warning "$out"` -ne 1 ]
then false; else true; fi

out=`guix lint -c description,synopsis dummy 2>&1`
if [ `grep_warning "$out"` -ne 3 ]
then false; else true; fi

if guix lint -c synopsis,invalid-checker dummy 2>&1 | \
   grep -q 'invalid-checker: invalid checker'
then true; else false; fi

# Make sure specifying multiple packages works.
guix lint -c inputs-should-be-native dummy dummy@42 dummy
357006351df386bc9'>tests</a>/<a href='/guix/log/gnu/tests/vnc.scm?id=afce1010475c1a4490ad379357006351df386bc9'>vnc.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/tests/vnc.scm?id=afce1010475c1a4490ad379357006351df386bc9&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2023-07-19 10:38:15 -0400'>2023-07-19</span></td><td><a href='/guix/commit/gnu/tests/vnc.scm?id=1edbadc6b49adda050a87057e6501c961888d7bb'>tests: xvnc: Fix 'gdm auto-suspend is disabled' test.</a><span class='msg-avail'>...<span class='msg-tooltip'>This failure is another collateral from commit a09c7da ("tests: Fork and exec
a new Guile for the marionette REPL."), which isolated the marionette
evaluation environment from that of the host.

* gnu/tests/vnc.scm (run-xvnc-test): Move the (guix build utils) import to...
["gdm auto-suspend is disabled"]: ... inside the marionette-eval of this
test.  Complete comment.

Reported-by: Bruno Victal &lt;mirai@makinata.eu&gt;
</span></span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2023-07-19 10:38:15 -0400'>2023-07-19</span></td><td><a href='/guix/commit/gnu/tests/vnc.scm?id=95424292993551854fb7373cef997fd39340ea4b'>tests: xvnc: Group up GDM test and use GNU Ocrad instead of Tesseract.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/tests/vnc.scm (run-xvnc-test): Group up GDM test.  Use GNU Ocrad.

Signed-off-by: Maxim Cournoyer &lt;maxim.cournoyer@gmail.com&gt;
Modified-by: Maxim Cournoyer &lt;maxim.cournoyer@gmail.com&gt;
</span></span></td><td>Bruno Victal</td></tr>
<tr><td><span title='2022-10-07 15:08:05 -0400'>2022-10-07</span></td><td><a href='/guix/commit/gnu/tests/vnc.scm?id=0169aee33e154c1fa8b299c7f126f3e94a8dc9a4'>tests: xvnc: Do not use specification-&gt;package in OS definition.</a><span class='msg-avail'>...<span class='msg-tooltip'>Doing so would cause the extra package dependencies to not be
correctly registered as dependencies, which would lead to a silent
failure when attempting to load or byte compile the module at the time
guix build itself (e.g., when running 'guix pull').

* gnu/tests/vnc.scm (%xvnc-os) [packages]: Turn the the
specification-&gt;package declaration into a list of package objects.
</span></span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2022-10-07 15:07:48 -0400'>2022-10-07</span></td><td><a href='/guix/commit/gnu/tests/vnc.scm?id=00e843050012961e9cc41b003ea9271eab718541'>Revert "Revert "services: Add xvnc-service-type.""</a><span class='msg-avail'>...<span class='msg-tooltip'>This reverts commit 0c4966160054bc50e6ab3a4ac9c9a6a1826ab5a0.  The fix appears
in the subsequent commit, for clarity.
</span></span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2022-10-07 12:53:22 -0400'>2022-10-07</span></td><td><a href='/guix/commit/gnu/tests/vnc.scm?id=0c4966160054bc50e6ab3a4ac9c9a6a1826ab5a0'>Revert "services: Add xvnc-service-type."</a><span class='msg-avail'>...<span class='msg-tooltip'>This reverts commit 1c528a95cb92b7808e6603d7956185005583629f.  This broke
'guix pull', for (yet) unknown reasons.
</span></span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2022-10-07 10:11:13 -0400'>2022-10-07</span></td><td><a href='/guix/commit/gnu/tests/vnc.scm?id=1c528a95cb92b7808e6603d7956185005583629f'>services: Add xvnc-service-type.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/services/vnc.scm: New file.
* gnu/tests/vnc.scm: Likewise.
* gnu/local.mk: Register them.
</span></span></td><td>Maxim Cournoyer</td></tr>