-----BEGIN PGP PRIVATE KEY BLOCK-----

lFgEXqNaoBYJKwYBBAHaRw8BAQdArviKtelb4g0I3zx9xyDS40Oz8i1/LRXqppG6
b23HdikAAQDGgjcUcvqR+nGYcf5UHzy9xlO/dBZX4f9QV1ILDIGt0hAYtChFZCBU
d28tRmlmdHkgPGx1ZG8rdGVzdC1lY2NAY2hib3VpYi5vcmc+iJYEExYIAD4WIQRE
0x4hr3E4+bYyKAp3H0nL+q4HLQUCXqNaoAIbAwUJA8JnAAULCQgHAgYVCgkICwIE
FgIDAQIeAQIXgAAKCRB3H0nL+q4HLauDAP9UfRtK6BMKx8Jk3Qx8bdtdXi6rqcFx
NGe8WNhR+gx5PQD+KMBHnwVO40Ka0gMwUvnOoHUt0ggiiqgIek6GeC5mygM=
=VjjI
-----END PGP PRIVATE KEY BLOCK-----
'><img src='https://git.koszko.org/cgit-static/cgit.png' alt='cgit logo'/></a></td>
<td class='main'><a href='/'>index</a> : <a href='/guix/'>guix</a></td><td class='form'><form method='get'>
<input type='hidden' name='id' value='4b0fcbd00a67a9adae79e1f838cebe8d74e4d734'/><input type='hidden' name='showmsg' value='1'/><select name='h' onchange='this.form.submit();'>
<option value='koszko' selected='selected'>koszko</option>
<option value='koszko-scripts'>koszko-scripts</option>
</select> <input type='submit' value='switch'/></form></td></tr>
<tr><td class='sub'>Wojtek's customized Guix</td><td class='sub right'></td></tr></table>
<table class='tabs'><tr><td>
<a href='/guix/about/'>about</a><a href='/guix/'>summary</a><a href='/guix/refs/?id=4b0fcbd00a67a9adae79e1f838cebe8d74e4d734'>refs</a><a class='active' href='/guix/log/gnu/installer/tests.scm?showmsg=1'>log</a><a href='/guix/tree/gnu/installer/tests.scm?id=4b0fcbd00a67a9adae79e1f838cebe8d74e4d734'>tree</a><a href='/guix/commit/gnu/installer/tests.scm?id=4b0fcbd00a67a9adae79e1f838cebe8d74e4d734'>commit</a><a href='/guix/diff/gnu/installer/tests.scm?id=4b0fcbd00a67a9adae79e1f838cebe8d74e4d734'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/installer/tests.scm'>
<input type='hidden' name='id' value='4b0fcbd00a67a9adae79e1f838cebe8d74e4d734'/><input type='hidden' name='showmsg' value='1'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=4b0fcbd00a67a9adae79e1f838cebe8d74e4d734&amp;showmsg=1'>root</a>/<a href='/guix/log/gnu?id=4b0fcbd00a67a9adae79e1f838cebe8d74e4d734&amp;showmsg=1'>gnu</a>/<a href='/guix/log/gnu/installer?id=4b0fcbd00a67a9adae79e1f838cebe8d74e4d734&amp;showmsg=1'>installer</a>/<a href='/guix/log/gnu/installer/tests.scm?id=4b0fcbd00a67a9adae79e1f838cebe8d74e4d734&amp;showmsg=1'>tests.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/installer/tests.scm?id=4b0fcbd00a67a9adae79e1f838cebe8d74e4d734'>Collapse</a>)</th><th class='left'>Author</th></tr>
<tr class='logheader'><td><span title='2022-09-24 14:15:47 +0200'>2022-09-24</span></td><td class='logsubject'><a href='/guix/commit/gnu/installer/tests.scm?id=f38e91a84c7d5ca72ddfccdf0ed8a3f0917054c0'>installer: tests: Fix typo.</a></td><td>Mathieu Othacehe</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
* gnu/installer/tests.scm (edit-configuration-file): Fix it.


</td></tr>
<tr class='logheader'><td><span title='2022-09-24 12:48:16 +0200'>2022-09-24</span></td><td class='logsubject'><a href='/guix/commit/gnu/installer/tests.scm?id=fe4663ae2476cb527d4f1f49ff8fa077d43f7251'>installer: Fix configuration edition during testing.</a></td><td>Mathieu Othacehe</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
When the configuration is edited, it looks like there are some leftover
fragments from the input configuration:

Example content of config.scm after edition:

  #:imported-modules
  '((gnu services herd)
    (guix build utils)
    (guix combinators)))

unted".  The unique
  ;; file system identifiers there ("UUIDs") can be obtained
  ;; by running 'blkid' in a terminal.

...

This is strange because call-with-output-file uses the O_TRUNC flag which
resets the file size to zero. Remove the configuration file before writing it
as a work-around.

* gnu/installer/tests.scm (edit-configuration-file): Remove the configuration
file before re-writing it.


</td></tr>
<tr class='logheader'><td><span title='2021-12-28 15:26:39 -0500'>2021-12-28</span></td><td class='logsubject'><a href='/guix/commit/gnu/installer/tests.scm?id=2842a42b518227607fed4470b0de1c84e3511beb'>installer: Recommend 'ntp-service-type' for non-graphical systems.</a></td><td>Leo Famulari</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
We had several bug reports with a root cause of "the clock was
incorrect" from users who used the installer to install a non-graphical
Guix System.

* gnu/installer/services.scm (%system-services): Add the ntp-service-type.
* gnu/installer/newt/services.scm (run-system-administration-cbt-page): New
variable.
(run-services-page): Use run-system-administration-cbt-page when not
installing a desktop.
* gnu/installer/tests.scm (choose-services): Add and use a
choose-misc-service?  procedure.
* gnu/tests/install.scm (installation-target-os-for-gui-tests)&lt;services&gt;: Add
ntp-service-type.


</td></tr>
<tr class='logheader'><td><span title='2021-12-28 15:26:39 -0500'>2021-12-28</span></td><td class='logsubject'><a href='/guix/commit/gnu/installer/tests.scm?id=029f8d7c120f80475aee6100e4f682bc7ab8f1f9'>installer: Offer the CUPS printing service on a dedicated page.</a></td><td>Leo Famulari</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
Currently, the installer page RUN-OTHER-SERVICES-CBT-PAGE offers to the user all
installer services that are not of the types 'desktop', 'network-management', or
'networking'. Concretely, this means that it offers the CUPS printing service,
because that is the only service of a different type defined in the installer.

In later commits, we will add some services of a new type, and we only want them
to be offered when the user is installing a non-graphical system.

At least one of these new services (NTP) is part of %DESKTOP-SERVICES. If it
was also offered on RUN-OTHER-SERVICES-CBT-PAGE, and the user had configured a
system using %DESKTOP-SERVICES, the user could accidentally add NTP to their
services twice, which is an error and would break installation.

So, this commit makes the RUN-OTHER-SERVICES-CBT-PAGE be more specific about
what services to offer. This makes it easier to discriminate between desktop and
non-desktop installations, in terms of when a given service is offered.

* gnu/installer/newt/services.scm (RUN-OTHER-SERVICES-CBT-PAGE): Rename to ...
(RUN-PRINTING-SERVICES-CBT-PAGE): ... new variable, and select only 'document' services.
(RUN-SERVICES-PAGE): Adjust accordingly.
* gnu/installer/tests.scm (CHOOSE-SERVICES): Adjust accordingly.


</td></tr>