From 05442de962d3dc624f79fc1a00eca3ffc5489ced Mon Sep 17 00:00:00 2001
From: Michal Srb <msrb@suse.com>
Date: Wed, 24 May 2017 15:54:39 +0300
Subject: Xi: Zero target buffer in SProcXSendExtensionEvent.

Make sure that the xEvent eventT is initialized with zeros, the same way as
in SProcSendEvent.

Some event swapping functions do not overwrite all 32 bytes of xEvent
structure, for example XSecurityAuthorizationRevoked. Two cooperating
clients, one swapped and the other not, can send
XSecurityAuthorizationRevoked event to each other to retrieve old stack data
from X server. This can be potentialy misused to go around ASLR or
stack-protector.

Signed-off-by: Michal Srb <msrb@suse.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

diff --git a/Xi/sendexev.c b/Xi/sendexev.c
index 11d8202..1cf118a 100644
--- a/Xi/sendexev.c
+++ b/Xi/sendexev.c
@@ -78,7 +78,7 @@ SProcXSendExtensionEvent(ClientPtr client)
 {
     CARD32 *p;
     int i;
-    xEvent eventT;
+    xEvent eventT = { .u.u.type = 0 };
     xEvent *eventP;
     EventSwapPtr proc;
 
-- 
cgit v0.10.2

><a class='active' href='/guix/log/tests/hexpm.scm'>log</a><a href='/guix/tree/tests/hexpm.scm?id=9a7899738ac95866844c938d612a0e1e87da3cf2'>tree</a><a href='/guix/commit/tests/hexpm.scm?id=9a7899738ac95866844c938d612a0e1e87da3cf2'>commit</a><a href='/guix/diff/tests/hexpm.scm?id=9a7899738ac95866844c938d612a0e1e87da3cf2'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/tests/hexpm.scm'>
<input type='hidden' name='id' value='9a7899738ac95866844c938d612a0e1e87da3cf2'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=9a7899738ac95866844c938d612a0e1e87da3cf2'>root</a>/<a href='/guix/log/tests?id=9a7899738ac95866844c938d612a0e1e87da3cf2'>tests</a>/<a href='/guix/log/tests/hexpm.scm?id=9a7899738ac95866844c938d612a0e1e87da3cf2'>hexpm.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/tests/hexpm.scm?id=9a7899738ac95866844c938d612a0e1e87da3cf2&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2024-06-03 22:58:53 +0200'>2024-06-03</span></td><td><a href='/guix/commit/tests/hexpm.scm?id=510ad5d93c0ba6208aa42815863853ec522352e6'>import: utils: End package descriptions with period.</a><span class='msg-avail'>...<span class='msg-tooltip'>* guix/import/utils.scm (beautify-description): Append period to last
words which do not end with one.
* tests/crate.scm: Append period to descriptions.
* tests/elm.scm: Append period to descriptions.
* tests/gem.scm: Append period to descriptions.
* tests/hexpm.scm: Append period to descriptions.
* tests/minetest.scm: Append period to descriptions.
* tests/pypi.scm: Append period to descriptions.
* tests/import-utils.scm ("beautify-description: transform fragment into
sentence"): Likewise.

Change-Id: I0b12c4d94cb26cf62fab5b7cbf7885e66ff6c10f
Signed-off-by: Ludovic Courtès &lt;ludo@gnu.org&gt;
</span></span></td><td>Herman Rimm</td></tr>