From 3121eeb5e68bedd6e2398f35b9bd60b69709a47e Mon Sep 17 00:00:00 2001
From: Josselin Poiret <dev@jpoiret.xyz>
Date: Tue, 14 Dec 2021 18:49:54 +0100
Subject: [PATCH] Replace hardcoded command length

---
 src/screenshot/screenshot.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/screenshot/screenshot.c b/src/screenshot/screenshot.c
index 9df0ea7..5f27681 100644
--- a/src/screenshot/screenshot.c
+++ b/src/screenshot/screenshot.c
@@ -42,8 +42,9 @@ static bool exec_screenshooter_interactive(const char *path) {
 		perror("fork");
 		return false;
 	} else if (pid == 0) {
-		char cmd[strlen(path) + 25];
-		snprintf(cmd, sizeof(cmd), "grim -g \"$(slurp)\" -- %s", path);
+		const char cmd_fmt[] = "grim -g \"$(slurp)\" -- %s";
+		char cmd[strlen(path) + sizeof(cmd_fmt)];
+		snprintf(cmd, sizeof(cmd), cmd_fmt, path);
 		execl("/bin/sh", "/bin/sh", "-c", cmd, NULL);
 		perror("execl");
 		exit(127);
-- 
2.34.0

 Guix</td><td class='sub right'></td></tr></table>
<table class='tabs'><tr><td>
<a href='/guix/about/'>about</a><a href='/guix/'>summary</a><a href='/guix/refs/?id=e5924771d10ccb311070163e23a96e919ed46434'>refs</a><a class='active' href='/guix/log/bootstrap?showmsg=1'>log</a><a href='/guix/tree/bootstrap?id=e5924771d10ccb311070163e23a96e919ed46434'>tree</a><a href='/guix/commit/bootstrap?id=e5924771d10ccb311070163e23a96e919ed46434'>commit</a><a href='/guix/diff/bootstrap?id=e5924771d10ccb311070163e23a96e919ed46434'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/bootstrap'>
<input type='hidden' name='id' value='e5924771d10ccb311070163e23a96e919ed46434'/><input type='hidden' name='showmsg' value='1'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=e5924771d10ccb311070163e23a96e919ed46434&amp;showmsg=1'>root</a>/<a href='/guix/log/bootstrap?id=e5924771d10ccb311070163e23a96e919ed46434&amp;showmsg=1'>bootstrap</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/bootstrap?id=e5924771d10ccb311070163e23a96e919ed46434'>Collapse</a>)</th><th class='left'>Author</th></tr>
<tr class='logheader'><td><span title='2024-04-19 16:45:41 +0200'>2024-04-19</span></td><td class='logsubject'><a href='/guix/commit/bootstrap?id=2b8a2a6e723a0cf987c814865df9368e6348b6f8'>maint: Generate doc/version[-LANG].texi using `mdate-from-git.scm'.</a></td><td>Janneke Nieuwenhuizen</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
This replaces Automake's `build-aux/mdate-sh' with our own
`build-aux/mdate-from-git.scm' to use reproducible timestamps from Git
instead.

* build-aux/mdate-from-git.scm: New script.
* bootstrap: Use it to replace build-aux/mdate-sh.
* Makefile.am (EXTRA_DIST): Add it.

Change-Id: I17d0a7de9ffea397129c0db1728f86e28a4e245f


</td></tr>
<tr class='logheader'><td><span title='2021-06-13 20:46:01 +0200'>2021-06-13</span></td><td class='logsubject'><a href='/guix/commit/bootstrap?id=bd02e50a02ceed914135dba1e69e4457e489cf86'>bootstrap: Simplify search for translation languages.</a></td><td>Hartmut Goebel</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
Extend the sed script to also behave like "basename",
saving the addtional call of "xargs basename".

* bootstrap (langs): Extend sed scripts, remove running xargs.


</td></tr>