This patch fixes an issue in virt-manager 4.1.0 where it errors and returns a stack trace. Namely, Gdk.Cursor.new_from_name yields a "constructor returned NULL" error, which causes a "'NoneType' object has no attribute 'conn'" error later. See the upstream bug report for more information: https://github.com/virt-manager/virt-manager/issues/479 Patch copied from upstream source repository: https://github.com/virt-manager/virt-manager/commit/cc4a39ea94f42bc92765eb3bb56e2b7f9198be67 From cc4a39ea94f42bc92765eb3bb56e2b7f9198be67 Mon Sep 17 00:00:00 2001 From: Cole Robinson Date: Thu, 19 Jan 2023 11:13:56 -0500 Subject: [PATCH] asyncjob: Fix backtrace when no cursor theme installed Fixes: https://github.com/virt-manager/virt-manager/issues/479 Signed-off-by: Cole Robinson --- virtManager/asyncjob.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/virtManager/asyncjob.py b/virtManager/asyncjob.py index 32d9c0a16..46692acea 100644 --- a/virtManager/asyncjob.py +++ b/virtManager/asyncjob.py @@ -265,9 +265,7 @@ def run(self): self.topwin.present() if not self.cancel_cb and self.show_progress: - gdk_window = self.topwin.get_window() - gdk_window.set_cursor( - Gdk.Cursor.new_from_name(gdk_window.get_display(), "progress")) + self._set_cursor("progress") self._bg_thread.start() ce.in?id=9600e345c1eff163bfb24f7c108ae06e096108a5'>diff
AgeCommit message (Expand)Author
2024-03-11etc: systemd services: switch to "journal" for output and error logging....The "syslog" method has been deprecated for years, and issues a warning: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether. Fixes: #48323 * etc/guix-daemon.service.in (StandardOutput): Use "journal" (StandardError): Likewise. * etc/guix-publish.service.in (StandardOutput): Likewise. (StandardError): Likewise. Vagrant Cascadian
2022-10-23etc: systemd services shouldn't ‘RemainAfterExit’....* etc/guix-daemon.service.in (RemainAfterExit): Don't. * etc/guix-publish.service.in (RemainAfterExit): Likewise don't. Tobias Geerinckx-Rice
2022-10-23etc: Add ‘Restart=always’ to both systemd services....* etc/guix-daemon.service.in (Restart): ‘Always’ do. * etc/guix-publish.service.in (Restart): Likewise. Tobias Geerinckx-Rice