This patch fixes an issue in virt-manager 4.1.0 where it errors and returns a stack trace. Namely, Gdk.Cursor.new_from_name yields a "constructor returned NULL" error, which causes a "'NoneType' object has no attribute 'conn'" error later. See the upstream bug report for more information: https://github.com/virt-manager/virt-manager/issues/479 Patch copied from upstream source repository: https://github.com/virt-manager/virt-manager/commit/cc4a39ea94f42bc92765eb3bb56e2b7f9198be67 From cc4a39ea94f42bc92765eb3bb56e2b7f9198be67 Mon Sep 17 00:00:00 2001 From: Cole Robinson Date: Thu, 19 Jan 2023 11:13:56 -0500 Subject: [PATCH] asyncjob: Fix backtrace when no cursor theme installed Fixes: https://github.com/virt-manager/virt-manager/issues/479 Signed-off-by: Cole Robinson --- virtManager/asyncjob.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/virtManager/asyncjob.py b/virtManager/asyncjob.py index 32d9c0a16..46692acea 100644 --- a/virtManager/asyncjob.py +++ b/virtManager/asyncjob.py @@ -265,9 +265,7 @@ def run(self): self.topwin.present() if not self.cancel_cb and self.show_progress: - gdk_window = self.topwin.get_window() - gdk_window.set_cursor( - Gdk.Cursor.new_from_name(gdk_window.get_display(), "progress")) + self._set_cursor("progress") self._bg_thread.start() 45ad970f5c5e3827b44'>diff
path: root/tests/guix-download.sh
AgeCommit message (Expand)Author
2023-04-21tests: Fix checks for expected failures....Addresses <https://issues.guix.gnu.org/62406>. With 'set -e', a return status inverted with '!' does not cause the shell to exit immediately. Instead use '&& false' to indicate an expected failure. * tests/guix-archive.sh, tests/guix-build-branch.sh, tests/guix-build.sh, tests/guix-daemon.sh, tests/guix-download.sh, tests/guix-environment-container.sh, tests/guix-environment.sh, tests/guix-gc.sh, tests/guix-git-authenticate.sh, tests/guix-graph.sh, tests/guix-hash.sh, tests/guix-home.sh, tests/guix-pack-relocatable.sh, tests/guix-pack.sh, tests/guix-package-aliases.sh, tests/guix-package-net.sh, tests/guix-package.sh, tests/guix-refresh.sh, tests/guix-shell.sh, tests/guix-style.sh, tests/guix-system.sh: Replace uses of '! ...' with '... && false' or `test ! ...` as appropriate. Signed-off-by: Ludovic Courtès <ludo@gnu.org> Eric Bavier
2020-09-28tests: Simplify shell exit status negation;...* tests/guix-archive.sh, tests/guix-build-branch.sh, tests/guix-build.sh, tests/guix-daemon.sh, tests/guix-download.sh, tests/guix-environment.sh, tests/guix-gc.sh, tests/guix-git-authenticate.sh, tests/guix-graph.sh, tests/guix-hash.sh, tests/guix-lint.sh, tests/guix-pack-relocatable.sh, tests/guix-pack.sh, tests/guix-package-aliases.sh, tests/guix-package-net.sh, tests/guix-package.sh: Use the shell '!' keyword to negate command exit status in place of 'if ...; then false; else true; fi' Eric Bavier
2017-08-20guix download: Support retrieving local file without the URI scheme....* guix/scripts/download.scm (guix-download): Treat the URL argument as a local file path when it fails on 'string->uri'. Call 'fetch' with the processed 'uri' instead of the original URL argument. * tests/guix-download.sh: Adjust accordingly. 宋文武
2016-11-16guix download: Add '-o' option....* guix/scripts/download.scm (download-to-file, download-to-store*): New procedures. (%default-options): Add 'download-proc'. (show-help): Adjust description and document '-o'. (%options): Add '-o'. (guix-download): Remove 'store' variable. Add 'fetch' and define 'path' to as its result. * tests/guix-download.sh: Add test. Ludovic Courtès