From: sms
Subject: Fix CVE-2014-8140: out-of-bounds write issue in test_compr_eb()
Bug-Debian: http://bugs.debian.org/773722

--- a/extract.c
+++ b/extract.c
@@ -2234,10 +2234,17 @@
     if (compr_offset < 4)                /* field is not compressed: */
         return PK_OK;                    /* do nothing and signal OK */
 
+    /* Return no/bad-data error status if any problem is found:
+     *    1. eb_size is too small to hold the uncompressed size
+     *       (eb_ucsize).  (Else extract eb_ucsize.)
+     *    2. eb_ucsize is zero (invalid).  2014-12-04 SMS.
+     *    3. eb_ucsize is positive, but eb_size is too small to hold
+     *       the compressed data header.
+     */
     if ((eb_size < (EB_UCSIZE_P + 4)) ||
-        ((eb_ucsize = makelong(eb+(EB_HEADSIZE+EB_UCSIZE_P))) > 0L &&
-         eb_size <= (compr_offset + EB_CMPRHEADLEN)))
-        return IZ_EF_TRUNC;               /* no compressed data! */
+     ((eb_ucsize = makelong( eb+ (EB_HEADSIZE+ EB_UCSIZE_P))) == 0L) ||
+     ((eb_ucsize > 0L) && (eb_size <= (compr_offset + EB_CMPRHEADLEN))))
+        return IZ_EF_TRUNC;             /* no/bad compressed data! */
 
     if (
 #ifdef INT_16BIT
ctive' href='/guix/log/gnu/build/bootloader.scm'>log</a><a href='/guix/tree/gnu/build/bootloader.scm?id=36908ef9f0af65bf32949a427c27410980d70b49'>tree</a><a href='/guix/commit/gnu/build/bootloader.scm?id=36908ef9f0af65bf32949a427c27410980d70b49'>commit</a><a href='/guix/diff/gnu/build/bootloader.scm?id=36908ef9f0af65bf32949a427c27410980d70b49'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/build/bootloader.scm'>
<input type='hidden' name='id' value='36908ef9f0af65bf32949a427c27410980d70b49'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=36908ef9f0af65bf32949a427c27410980d70b49'>root</a>/<a href='/guix/log/gnu?id=36908ef9f0af65bf32949a427c27410980d70b49'>gnu</a>/<a href='/guix/log/gnu/build?id=36908ef9f0af65bf32949a427c27410980d70b49'>build</a>/<a href='/guix/log/gnu/build/bootloader.scm?id=36908ef9f0af65bf32949a427c27410980d70b49'>bootloader.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/build/bootloader.scm?id=36908ef9f0af65bf32949a427c27410980d70b49&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2019-06-17 16:13:36 +0200'>2019-06-17</span></td><td><a href='/guix/commit/gnu/build/bootloader.scm?id=45d46223f92b0933aaf9b1392a21d09eaa1e2881'>utils: Add 'invoke/quiet'.</a><span class='msg-avail'>...</span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2019-03-16 18:15:13 +0100'>2019-03-16</span></td><td><a href='/guix/commit/gnu/build/bootloader.scm?id=f0cc5e7e1e4c03af29c5d4855dc5962502c49147'>booloader: Add 'invoke/quiet'.</a><span class='msg-avail'>...</span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2017-12-15 11:52:38 +0100'>2017-12-15</span></td><td><a href='/guix/commit/gnu/build/bootloader.scm?id=e22482038611a53a9d2b25df20363664cd91be2e'>bootloader: Factorize write-file-on-device.</a><span class='msg-avail'>...</span></td><td>Mathieu Othacehe</td></tr>