From: sms
Subject: Fix CVE-2014-8140: out-of-bounds write issue in test_compr_eb()
Bug-Debian: http://bugs.debian.org/773722

--- a/extract.c
+++ b/extract.c
@@ -2234,10 +2234,17 @@
     if (compr_offset < 4)                /* field is not compressed: */
         return PK_OK;                    /* do nothing and signal OK */
 
+    /* Return no/bad-data error status if any problem is found:
+     *    1. eb_size is too small to hold the uncompressed size
+     *       (eb_ucsize).  (Else extract eb_ucsize.)
+     *    2. eb_ucsize is zero (invalid).  2014-12-04 SMS.
+     *    3. eb_ucsize is positive, but eb_size is too small to hold
+     *       the compressed data header.
+     */
     if ((eb_size < (EB_UCSIZE_P + 4)) ||
-        ((eb_ucsize = makelong(eb+(EB_HEADSIZE+EB_UCSIZE_P))) > 0L &&
-         eb_size <= (compr_offset + EB_CMPRHEADLEN)))
-        return IZ_EF_TRUNC;               /* no compressed data! */
+     ((eb_ucsize = makelong( eb+ (EB_HEADSIZE+ EB_UCSIZE_P))) == 0L) ||
+     ((eb_ucsize > 0L) && (eb_size <= (compr_offset + EB_CMPRHEADLEN))))
+        return IZ_EF_TRUNC;             /* no/bad compressed data! */
 
     if (
 #ifdef INT_16BIT
s='active' href='/guix/log/gnu/services/telephony.scm'>log</a><a href='/guix/tree/gnu/services/telephony.scm?id=d25620be4c545aec1653ecc40ebb7ea2dd1a12ae'>tree</a><a href='/guix/commit/gnu/services/telephony.scm?id=d25620be4c545aec1653ecc40ebb7ea2dd1a12ae'>commit</a><a href='/guix/diff/gnu/services/telephony.scm?id=d25620be4c545aec1653ecc40ebb7ea2dd1a12ae'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/services/telephony.scm'>
<input type='hidden' name='id' value='d25620be4c545aec1653ecc40ebb7ea2dd1a12ae'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=d25620be4c545aec1653ecc40ebb7ea2dd1a12ae'>root</a>/<a href='/guix/log/gnu?id=d25620be4c545aec1653ecc40ebb7ea2dd1a12ae'>gnu</a>/<a href='/guix/log/gnu/services?id=d25620be4c545aec1653ecc40ebb7ea2dd1a12ae'>services</a>/<a href='/guix/log/gnu/services/telephony.scm?id=d25620be4c545aec1653ecc40ebb7ea2dd1a12ae'>telephony.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/services/telephony.scm?id=d25620be4c545aec1653ecc40ebb7ea2dd1a12ae&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2023-12-22 00:31:41 +0100'>2023-12-22</span></td><td><a href='/guix/commit/gnu/services/telephony.scm?id=62a08abea75b234b2ada905acb9df27406c6f1d2'>services: jami: Use ‘least-authority-wrapper’.</a><span class='msg-avail'>...</span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2023-12-22 00:31:41 +0100'>2023-12-22</span></td><td><a href='/guix/commit/gnu/services/telephony.scm?id=8bd1c14997fe2393e79c19ff5f3230a88cfb9abc'>services: jami-dbus-session: Use ‘least-authority-wrapper’.</a><span class='msg-avail'>...</span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2023-10-07 12:41:06 -0400'>2023-10-07</span></td><td><a href='/guix/commit/gnu/services/telephony.scm?id=00a28bc435606dc98925fbae1ebe314881f35c90'>services: configuration: Add some commonly used predicates.</a><span class='msg-avail'>...</span></td><td>Bruno Victal</td></tr>
<tr><td><span title='2023-10-07 12:41:05 -0400'>2023-10-07</span></td><td><a href='/guix/commit/gnu/services/telephony.scm?id=a7994ed58dc1ac3b57aa2df8508f05fd0748b3e0'>services: configuration: Use transducers within serialize-configuration.</a><span class='msg-avail'>...</span></td><td>Bruno Victal</td></tr>
<tr><td><span title='2023-02-08 09:36:26 -0500'>2023-02-08</span></td><td><a href='/guix/commit/gnu/services/telephony.scm?id=aef75942fc24fdb753978848b5471c5da21f23b7'>gnu: libjami: Move jamid daemon to a "bin" output.</a><span class='msg-avail'>...</span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2022-09-23 23:56:16 -0400'>2022-09-23</span></td><td><a href='/guix/commit/gnu/services/telephony.scm?id=effdc6c83e7000bf062526f4256de69899e13b40'>services: jami-service-type: Streamline stop slot.</a><span class='msg-avail'>...</span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2022-08-25 00:10:32 -0400'>2022-08-25</span></td><td><a href='/guix/commit/gnu/services/telephony.scm?id=ee08277a70d29b6d707524a4e17620f50b87adf4'>services: Use the new maybe/unset API.</a><span class='msg-avail'>...</span></td><td>Attila Lendvai</td></tr>
<tr><td><span title='2022-08-01 12:49:35 -0400'>2022-08-01</span></td><td><a href='/guix/commit/gnu/services/telephony.scm?id=a2b89a3319dc1d621c546855f578acae5baaf6da'>services: configuration: Step back from *unspecified*.</a><span class='msg-avail'>...</span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2022-06-15 00:25:21 +0200'>2022-06-15</span></td><td><a href='/guix/commit/gnu/services/telephony.scm?id=8cb1a49a3998c39f315a4199b7d4a121a6d66449'>services: configuration: Use *unspecified* instead of 'disabled.</a><span class='msg-avail'>...</span></td><td>Attila Lendvai</td></tr>
<tr><td><span title='2022-06-10 23:52:34 -0400'>2022-06-10</span></td><td><a href='/guix/commit/gnu/services/telephony.scm?id=8649ac5eaa0447a766b18550787b60639e57a7fb'>services: jami-configuration: Rename 'jamid' field to 'libjami'.</a><span class='msg-avail'>...</span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2022-06-10 23:52:33 -0400'>2022-06-10</span></td><td><a href='/guix/commit/gnu/services/telephony.scm?id=85b4dabd94d53f8179f31a42046cd83fc3a352fc'>services: jami: Modernize to adjust to Shepherd 0.9+ changes.</a><span class='msg-avail'>...</span></td><td>Maxim Cournoyer</td></tr>