From: sms
Subject: Fix CVE-2014-8140: out-of-bounds write issue in test_compr_eb()
Bug-Debian: http://bugs.debian.org/773722

--- a/extract.c
+++ b/extract.c
@@ -2234,10 +2234,17 @@
     if (compr_offset < 4)                /* field is not compressed: */
         return PK_OK;                    /* do nothing and signal OK */
 
+    /* Return no/bad-data error status if any problem is found:
+     *    1. eb_size is too small to hold the uncompressed size
+     *       (eb_ucsize).  (Else extract eb_ucsize.)
+     *    2. eb_ucsize is zero (invalid).  2014-12-04 SMS.
+     *    3. eb_ucsize is positive, but eb_size is too small to hold
+     *       the compressed data header.
+     */
     if ((eb_size < (EB_UCSIZE_P + 4)) ||
-        ((eb_ucsize = makelong(eb+(EB_HEADSIZE+EB_UCSIZE_P))) > 0L &&
-         eb_size <= (compr_offset + EB_CMPRHEADLEN)))
-        return IZ_EF_TRUNC;               /* no compressed data! */
+     ((eb_ucsize = makelong( eb+ (EB_HEADSIZE+ EB_UCSIZE_P))) == 0L) ||
+     ((eb_ucsize > 0L) && (eb_size <= (compr_offset + EB_CMPRHEADLEN))))
+        return IZ_EF_TRUNC;             /* no/bad compressed data! */
 
     if (
 #ifdef INT_16BIT
og/tests/services'>log</a><a href='/guix/tree/tests/services?id=de646bd5da810b8c062de1326ac75fd25d6bba57'>tree</a><a href='/guix/commit/tests/services?id=de646bd5da810b8c062de1326ac75fd25d6bba57'>commit</a><a href='/guix/diff/tests/services?id=de646bd5da810b8c062de1326ac75fd25d6bba57'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/tests/services'>
<input type='hidden' name='id' value='de646bd5da810b8c062de1326ac75fd25d6bba57'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=de646bd5da810b8c062de1326ac75fd25d6bba57'>root</a>/<a href='/guix/log/tests?id=de646bd5da810b8c062de1326ac75fd25d6bba57'>tests</a>/<a href='/guix/log/tests/services?id=de646bd5da810b8c062de1326ac75fd25d6bba57'>services</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/tests/services?id=de646bd5da810b8c062de1326ac75fd25d6bba57&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2023-04-02 12:35:30 +0200'>2023-04-02</span></td><td><a href='/guix/commit/tests/services?id=0fbb356714f4ae3ea18e4997131a0e1746cc923c'>services: replace bare serializers with (serializer ...)</a><span class='msg-avail'>...</span></td><td>Bruno Victal</td></tr>
<tr><td><span title='2023-04-02 12:31:51 +0200'>2023-04-02</span></td><td><a href='/guix/commit/tests/services?id=6f48efa9b89f3c33f7b2827cae88e87ec64faa09'>services: configuration: Add user-defined sanitizer support.</a><span class='msg-avail'>...</span></td><td>Bruno Victal</td></tr>
<tr><td><span title='2022-08-28 22:28:47 -0400'>2022-08-28</span></td><td><a href='/guix/commit/tests/services?id=0ea62e84a787fe94cfeadf67ef27ea995a382b84'>services: Add lightdm-service-type.</a><span class='msg-avail'>...</span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2022-08-25 00:10:42 -0400'>2022-08-25</span></td><td><a href='/guix/commit/tests/services?id=6fb9759ef3b8eb2a2b10c3f02a57ece29b5c53ba'>services: configuration: Change the value of the unset marker.</a><span class='msg-avail'>...</span></td><td>Attila Lendvai</td></tr>
<tr><td><span title='2022-08-25 00:10:32 -0400'>2022-08-25</span></td><td><a href='/guix/commit/tests/services?id=ee08277a70d29b6d707524a4e17620f50b87adf4'>services: Use the new maybe/unset API.</a><span class='msg-avail'>...</span></td><td>Attila Lendvai</td></tr>
<tr><td><span title='2022-08-09 23:14:42 -0400'>2022-08-09</span></td><td><a href='/guix/commit/tests/services?id=97cb43e732a38758c95b7caf3963507188d011cf'>tests: configuration: Add a test to cover 'unset regression.</a><span class='msg-avail'>...</span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2022-08-01 12:49:35 -0400'>2022-08-01</span></td><td><a href='/guix/commit/tests/services?id=a2b89a3319dc1d621c546855f578acae5baaf6da'>services: configuration: Step back from *unspecified*.</a><span class='msg-avail'>...</span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2022-07-07 10:43:08 -0400'>2022-07-07</span></td><td><a href='/guix/commit/tests/services?id=258bc4c4e668e9817471d04d052bc0a8e2d43fa0'>tests: telephony: Remove obsolete parsing tests.</a><span class='msg-avail'>...</span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2022-06-24 23:18:20 +0200'>2022-06-24</span></td><td><a href='/guix/commit/tests/services?id=fb7e6ccba7cc243cd96cdc3fde3daa9a5f08e531'>services: configuration: Report the location of field type errors.</a><span class='msg-avail'>...</span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2022-06-15 00:25:21 +0200'>2022-06-15</span></td><td><a href='/guix/commit/tests/services?id=8cb1a49a3998c39f315a4199b7d4a121a6d66449'>services: configuration: Use *unspecified* instead of 'disabled.</a><span class='msg-avail'>...</span></td><td>Attila Lendvai</td></tr>
<tr><td><span title='2022-06-15 00:25:21 +0200'>2022-06-15</span></td><td><a href='/guix/commit/tests/services?id=e11517052b1bbd9fa06891ad0b13b24494db757e'>services: configuration: Support (field1 maybe-number "") format.</a><span class='msg-avail'>...</span></td><td>Attila Lendvai</td></tr>