From: sms
Subject: Fix CVE-2014-8140: out-of-bounds write issue in test_compr_eb()
Bug-Debian: http://bugs.debian.org/773722

--- a/extract.c
+++ b/extract.c
@@ -2234,10 +2234,17 @@
     if (compr_offset < 4)                /* field is not compressed: */
         return PK_OK;                    /* do nothing and signal OK */
 
+    /* Return no/bad-data error status if any problem is found:
+     *    1. eb_size is too small to hold the uncompressed size
+     *       (eb_ucsize).  (Else extract eb_ucsize.)
+     *    2. eb_ucsize is zero (invalid).  2014-12-04 SMS.
+     *    3. eb_ucsize is positive, but eb_size is too small to hold
+     *       the compressed data header.
+     */
     if ((eb_size < (EB_UCSIZE_P + 4)) ||
-        ((eb_ucsize = makelong(eb+(EB_HEADSIZE+EB_UCSIZE_P))) > 0L &&
-         eb_size <= (compr_offset + EB_CMPRHEADLEN)))
-        return IZ_EF_TRUNC;               /* no compressed data! */
+     ((eb_ucsize = makelong( eb+ (EB_HEADSIZE+ EB_UCSIZE_P))) == 0L) ||
+     ((eb_ucsize > 0L) && (eb_size <= (compr_offset + EB_CMPRHEADLEN))))
+        return IZ_EF_TRUNC;             /* no/bad compressed data! */
 
     if (
 #ifdef INT_16BIT
ive' href='/guix/log/etc/teams/qt/common.scm'>log</a><a href='/guix/tree/etc/teams/qt/common.scm?id=a13a63fd2ba1621e6fca11745334a6da2870e5ee'>tree</a><a href='/guix/commit/etc/teams/qt/common.scm?id=a13a63fd2ba1621e6fca11745334a6da2870e5ee'>commit</a><a href='/guix/diff/etc/teams/qt/common.scm?id=a13a63fd2ba1621e6fca11745334a6da2870e5ee'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/etc/teams/qt/common.scm'>
<input type='hidden' name='id' value='a13a63fd2ba1621e6fca11745334a6da2870e5ee'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=a13a63fd2ba1621e6fca11745334a6da2870e5ee'>root</a>/<a href='/guix/log/etc?id=a13a63fd2ba1621e6fca11745334a6da2870e5ee'>etc</a>/<a href='/guix/log/etc/teams?id=a13a63fd2ba1621e6fca11745334a6da2870e5ee'>teams</a>/<a href='/guix/log/etc/teams/qt?id=a13a63fd2ba1621e6fca11745334a6da2870e5ee'>qt</a>/<a href='/guix/log/etc/teams/qt/common.scm?id=a13a63fd2ba1621e6fca11745334a6da2870e5ee'>common.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/etc/teams/qt/common.scm?id=a13a63fd2ba1621e6fca11745334a6da2870e5ee&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2024-03-19 03:40:08 -0400'>2024-03-19</span></td><td><a href='/guix/commit/etc/teams/qt/common.scm?id=a8ba2f3507d03ec77506a03bf84d62f9cb439f8e'>teams: qt: Remove erroneous comment at top of scripts.</a><span class='msg-avail'>...</span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2023-08-22 12:32:20 -0400'>2023-08-22</span></td><td><a href='/guix/commit/etc/teams/qt/common.scm?id=0b994bb9b10b381376f1dfd8bd2bc9173ede2a66'>etc: Add Qt manifests for Qt maintenance.</a><span class='msg-avail'>...</span></td><td>Maxim Cournoyer</td></tr>