From: sms
Subject: Fix CVE-2014-8140: out-of-bounds write issue in test_compr_eb()
Bug-Debian: http://bugs.debian.org/773722

--- a/extract.c
+++ b/extract.c
@@ -2234,10 +2234,17 @@
     if (compr_offset < 4)                /* field is not compressed: */
         return PK_OK;                    /* do nothing and signal OK */
 
+    /* Return no/bad-data error status if any problem is found:
+     *    1. eb_size is too small to hold the uncompressed size
+     *       (eb_ucsize).  (Else extract eb_ucsize.)
+     *    2. eb_ucsize is zero (invalid).  2014-12-04 SMS.
+     *    3. eb_ucsize is positive, but eb_size is too small to hold
+     *       the compressed data header.
+     */
     if ((eb_size < (EB_UCSIZE_P + 4)) ||
-        ((eb_ucsize = makelong(eb+(EB_HEADSIZE+EB_UCSIZE_P))) > 0L &&
-         eb_size <= (compr_offset + EB_CMPRHEADLEN)))
-        return IZ_EF_TRUNC;               /* no compressed data! */
+     ((eb_ucsize = makelong( eb+ (EB_HEADSIZE+ EB_UCSIZE_P))) == 0L) ||
+     ((eb_ucsize > 0L) && (eb_size <= (compr_offset + EB_CMPRHEADLEN))))
+        return IZ_EF_TRUNC;             /* no/bad compressed data! */
 
     if (
 #ifdef INT_16BIT
g</a><a href='/guix/tree/gnu.scm?id=a50201fdc18067351e7d8e384b848430e125bbc6'>tree</a><a href='/guix/commit/gnu.scm?id=a50201fdc18067351e7d8e384b848430e125bbc6'>commit</a><a href='/guix/diff/gnu.scm?id=a50201fdc18067351e7d8e384b848430e125bbc6'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu.scm'>
<input type='hidden' name='id' value='a50201fdc18067351e7d8e384b848430e125bbc6'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=a50201fdc18067351e7d8e384b848430e125bbc6'>root</a>/<a href='/guix/log/gnu.scm?id=a50201fdc18067351e7d8e384b848430e125bbc6'>gnu.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu.scm?id=a50201fdc18067351e7d8e384b848430e125bbc6&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2020-07-25 19:11:37 +0200'>2020-07-25</span></td><td><a href='/guix/commit/gnu.scm?id=d51bfe242fbe6f3f8f71d723e8fe0c7bbe711ba1'>Use 'formatted-message' instead of '&amp;message' where appropriate.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu.scm (%try-use-modules): Use 'formatted-message' instead of
'&amp;message'.
* gnu/machine/digital-ocean.scm (maybe-raise-unsupported-configuration-error):
Likewise.
* gnu/machine/ssh.scm (machine-check-file-system-availability): Likewise.
(machine-check-building-for-appropriate-system): Likewise.
(deploy-managed-host): Likewise.
(maybe-raise-unsupported-configuration-error): Likewise.
* gnu/packages.scm (search-patch): Likewise.
* gnu/services.scm (%service-with-default-value): Likewise.
(files-&gt;etc-directory): Likewise.
(fold-services): Likewise.
* gnu/system.scm (locale-name-&gt;definition*): Likewise.
* gnu/system/mapped-devices.scm (check-device-initrd-modules): Likewise.
(check-luks-device): Likewise.
* guix/channels.scm (latest-channel-instance): Likewise.
* guix/cve.scm (json-&gt;cve-items): Likewise.
* guix/git-authenticate.scm (commit-signing-key): Likewise.
(commit-authorized-keys): Likewise.
(authenticate-commit): Likewise.
(verify-introductory-commit): Likewise.
* guix/remote.scm (remote-pipe-for-gexp): Likewise.
* guix/scripts/graph.scm (assert-package): Likewise.
* guix/scripts/offload.scm (private-key-from-file*): Likewise.
* guix/ssh.scm (authenticate-server*): Likewise.
(open-ssh-session): Likewise.
(remote-inferior): Likewise.
* guix/ui.scm (matching-generations): Likewise.
* guix/upstream.scm (package-update): Likewise.
* tests/channels.scm ("latest-channel-instances, missing introduction for 'guix'"):
Catch 'formatted-message?'.
("authenticate-channel, wrong first commit signer"): Likewise.
* tests/lint.scm ("patches: not found"): Adjust message string.
* tests/packages.scm ("patch not found yields a run-time error"): Catch
'formatted-message?'.
* guix/lint.scm (check-patch-file-names): Handle 'formatted-message?'.
(check-derivation): Ditto.
</span></span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2020-07-25 19:11:36 +0200'>2020-07-25</span></td><td><a href='/guix/commit/gnu.scm?id=f9a8dd053c4e0fd1fc4b64291bb90de36520b3bc'>utils: Move '&amp;fix-hint' to (guix diagnostics).</a><span class='msg-avail'>...<span class='msg-tooltip'>* guix/utils.scm (&amp;fix-hint): Move to...
* guix/diagnostics.scm (&amp;fix-hint): ... here.
* gnu.scm: Adjust imports accordingly.
* gnu/system/mapped-devices.scm: Likewise.
* guix/channels.scm: Likewise.
* guix/profiles.scm: Likewise.
* guix/scripts/system/reconfigure.scm: Likewise.
* guix/ssh.scm: Likewise.
</span></span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2020-07-25 19:11:36 +0200'>2020-07-25</span></td><td><a href='/guix/commit/gnu.scm?id=a5e2fc73760a2ae023f2e56bdbf8025971f90e64'>utils: Move &lt;location&gt; and '&amp;error-location' to (guix diagnostics).</a><span class='msg-avail'>...<span class='msg-tooltip'>* guix/utils.scm (&lt;location&gt;, source-properties-&gt;location)
(location-&gt;source-properties, &amp;error-location): Move to...
* guix/diagnostics.scm: ... here.
* gnu.scm: Adjust imports accordingly.
* gnu/machine.scm: Likewise.
* gnu/system.scm: Likewise.
* gnu/tests.scm: Likewise.
* guix/inferior.scm: Likewise.
* tests/channels.scm: Likewise.
* tests/packages.scm: Likewise.
</span></span></td><td>Ludovic Courtès</td></tr>