From: sms
Subject: Fix CVE-2014-8140: out-of-bounds write issue in test_compr_eb()
Bug-Debian: http://bugs.debian.org/773722

--- a/extract.c
+++ b/extract.c
@@ -2234,10 +2234,17 @@
     if (compr_offset < 4)                /* field is not compressed: */
         return PK_OK;                    /* do nothing and signal OK */
 
+    /* Return no/bad-data error status if any problem is found:
+     *    1. eb_size is too small to hold the uncompressed size
+     *       (eb_ucsize).  (Else extract eb_ucsize.)
+     *    2. eb_ucsize is zero (invalid).  2014-12-04 SMS.
+     *    3. eb_ucsize is positive, but eb_size is too small to hold
+     *       the compressed data header.
+     */
     if ((eb_size < (EB_UCSIZE_P + 4)) ||
-        ((eb_ucsize = makelong(eb+(EB_HEADSIZE+EB_UCSIZE_P))) > 0L &&
-         eb_size <= (compr_offset + EB_CMPRHEADLEN)))
-        return IZ_EF_TRUNC;               /* no compressed data! */
+     ((eb_ucsize = makelong( eb+ (EB_HEADSIZE+ EB_UCSIZE_P))) == 0L) ||
+     ((eb_ucsize > 0L) && (eb_size <= (compr_offset + EB_CMPRHEADLEN))))
+        return IZ_EF_TRUNC;             /* no/bad compressed data! */
 
     if (
 #ifdef INT_16BIT
ref='/guix/log/gnu/packages/efi.scm'>log</a><a href='/guix/tree/gnu/packages/efi.scm?id=33238b552000aa730d6e306df4fadbac2ad2db02'>tree</a><a href='/guix/commit/gnu/packages/efi.scm?id=33238b552000aa730d6e306df4fadbac2ad2db02'>commit</a><a href='/guix/diff/gnu/packages/efi.scm?id=33238b552000aa730d6e306df4fadbac2ad2db02'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/packages/efi.scm'>
<input type='hidden' name='id' value='33238b552000aa730d6e306df4fadbac2ad2db02'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=33238b552000aa730d6e306df4fadbac2ad2db02'>root</a>/<a href='/guix/log/gnu?id=33238b552000aa730d6e306df4fadbac2ad2db02'>gnu</a>/<a href='/guix/log/gnu/packages?id=33238b552000aa730d6e306df4fadbac2ad2db02'>packages</a>/<a href='/guix/log/gnu/packages/efi.scm?id=33238b552000aa730d6e306df4fadbac2ad2db02'>efi.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/packages/efi.scm?id=33238b552000aa730d6e306df4fadbac2ad2db02&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2019-02-12 18:08:19 +0200'>2019-02-12</span></td><td><a href='/guix/commit/gnu/packages/efi.scm?id=b856a78c949543da2cb829b36cb96e74309e8d35'>gnu: efilinux: Set ARCH variable on some architectures.</a><span class='msg-avail'>...<span class='msg-tooltip'>Even with this patch efilinux does not build for arm*.

* gnu/packages/efi.scm (efilinux)[arguments]: On armhf-linux and
aarch64-linux set the ARCH variable apropriately.
</span></span></td><td>Efraim Flashner</td></tr>
<tr><td><span title='2019-02-04 00:16:47 +0100'>2019-02-04</span></td><td><a href='/guix/commit/gnu/packages/efi.scm?id=c7797b75cc648489b811bc7b9485fb4e0cb79173'>gnu: efilinux: Fix indentation of source code.</a><span class='msg-avail'>...<span class='msg-tooltip'>Follow-up to 6adfcbeab1cbaf8ce6ff6f32aad5d72f94860cbb.

* gnu/packages/efi.scm (efilinux): Fix indentation of source code.
</span></span></td><td>Danny Milosavljevic</td></tr>
<tr><td><span title='2019-02-04 00:14:18 +0100'>2019-02-04</span></td><td><a href='/guix/commit/gnu/packages/efi.scm?id=bb4a8f4851c19a9d0a0ea55bab8aa802f09f6b6d'>gnu: Add efilinux.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/packages/efi.scm (efilinux): New variable.
</span></span></td><td>Danny Milosavljevic</td></tr>
<tr><td><span title='2019-02-04 00:14:18 +0100'>2019-02-04</span></td><td><a href='/guix/commit/gnu/packages/efi.scm?id=527aab6f1813d7c2a92ef6b831fb77278aacdef5'>gnu: Add efitools.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/packages/efi.scm (efitools): New variable.
</span></span></td><td>Danny Milosavljevic</td></tr>
<tr><td><span title='2019-02-04 00:14:18 +0100'>2019-02-04</span></td><td><a href='/guix/commit/gnu/packages/efi.scm?id=3da49652ad94298ff283e108562a0bfb4aea47ff'>gnu: Add sbsigntools.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/packages/efi.scm (sbsigntools): New variable.
</span></span></td><td>Danny Milosavljevic</td></tr>
<tr><td><span title='2019-02-04 00:14:16 +0100'>2019-02-04</span></td><td><a href='/guix/commit/gnu/packages/efi.scm?id=f8ff37d6c093e7cab16d1987139b4df92a7ae4ab'>gnu: Add gnu-efi.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/packages/efi.scm: New file.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
</span></span></td><td>Danny Milosavljevic</td></tr>