This patch fixes SLiM so it really waits for the X server to be ready before attempting to connect to it. Indeed, the X server notices that its parent process has a handler for SIGUSR1, and consequently sends it SIGUSR1 when it's ready to accept connections. The problem was that SLiM doesn't pay attention to SIGUSR1. So in practice, if X starts slowly, then SLiM gets ECONNREFUSED a couple of time on /tmp/.X11-unix/X0, then goes on trying to connect to localhost:6000, where nobody answers; eventually, it times out and tries again on /tmp/.X11-unix/X0, and finally it shows up on the screen. Patch by L. Courtès. --- slim-1.3.6/app.cpp 2014-02-05 15:27:20.000000000 +0100 +++ slim-1.3.6/app.cpp 2014-02-09 22:42:04.000000000 +0100 @@ -119,7 +119,9 @@ void CatchSignal(int sig) { exit(ERR_EXIT); } +static volatile int got_sigusr1 = 0; void User1Signal(int sig) { + got_sigusr1 = 1; signal(sig, User1Signal); } @@ -884,6 +886,7 @@ int App::WaitForServer() { int ncycles = 120; int cycles; + while (!got_sigusr1); for(cycles = 0; cycles < ncycles; cycles++) { if((Dpy = XOpenDisplay(DisplayName))) { XSetIOErrorHandler(xioerror); 7a08'>refslogtreecommitdiff
path: root/gnu/build/accounts.scm
AgeCommit message (Expand)Author
2023-10-12accounts: Fix typo in comment....* gnu/build/accounts.scm (passwd->shadow): Fix typo in comment. Ludovic Courtès
2023-10-08accounts: Ensure ‘last-change’ field of shadow entries is never zero....* gnu/build/accounts.scm (passwd->shadow): Add ‘max’ call so NOW is greater than or equal to 1. Ludovic Courtès
2022-01-01system: Allow 'chfn' to change the user's full name....Fixes <https://issues.guix.gnu.org/52539>. Reported by Jacob First <jacob.first@member.fsf.org>. * gnu/build/accounts.scm (allocate-passwd): Add comment as to why 'real-name' is taken from PREVIOUS. Add (not system?) to the condition. * gnu/system.scm (operating-system-etc-service) <login.defs>: Add "CHFN_RESTRICT". * gnu/system.scm (%setuid-programs): Add "chfn". * gnu/system/pam.scm (base-pam-services): Add "chfn". * doc/guix.texi (User Accounts): Document it. Ludovic Courtès