Patch from . From d9db29db567012b7c72e85e1be1fbf55fcc9b667 Mon Sep 17 00:00:00 2001 From: Niels De Graef Date: Sat, 11 May 2019 09:02:34 +0200 Subject: [PATCH] gkr: Use 0 on empty flags A Flags-type variable without any flag set can be replaced with 0, so this is a safe thing to do. It also prevents us from having to deal with the accidental API break in libsecret (see https://gitlab.gnome.org/GNOME/libsecret/merge_requests/19) --- gkr/gkr-keyring-add.vala | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gkr/gkr-keyring-add.vala b/gkr/gkr-keyring-add.vala index 4e92a520..f60c9a22 100644 --- a/gkr/gkr-keyring-add.vala +++ b/gkr/gkr-keyring-add.vala @@ -41,8 +41,7 @@ public class Seahorse.Gkr.KeyringAdd : Gtk.Dialog { var cancellable = Dialog.begin_request(this); var service = Backend.instance().service; - Secret.Collection.create.begin(service, this.name_entry.text, null, - Secret.CollectionCreateFlags.COLLECTION_CREATE_NONE, + Secret.Collection.create.begin(service, this.name_entry.text, null, 0, cancellable, (obj, res) => { /* Clear the operation without cancelling it since it is complete */ Dialog.complete_request(this, false); -- 2.23.0 a>diff
AgeCommit message (Expand)Author
2023-04-21tests: Fix checks for expected failures....Addresses <https://issues.guix.gnu.org/62406>. With 'set -e', a return status inverted with '!' does not cause the shell to exit immediately. Instead use '&& false' to indicate an expected failure. * tests/guix-archive.sh, tests/guix-build-branch.sh, tests/guix-build.sh, tests/guix-daemon.sh, tests/guix-download.sh, tests/guix-environment-container.sh, tests/guix-environment.sh, tests/guix-gc.sh, tests/guix-git-authenticate.sh, tests/guix-graph.sh, tests/guix-hash.sh, tests/guix-home.sh, tests/guix-pack-relocatable.sh, tests/guix-pack.sh, tests/guix-package-aliases.sh, tests/guix-package-net.sh, tests/guix-package.sh, tests/guix-refresh.sh, tests/guix-shell.sh, tests/guix-style.sh, tests/guix-system.sh: Replace uses of '! ...' with '... && false' or `test ! ...` as appropriate. Signed-off-by: Ludovic Courtès <ludo@gnu.org> Eric Bavier
2023-02-27pack: Adjust shell tests to read-only tarball root....Fixes <https://issues.guix.gnu.org/61853>. Fixes a regression introduced in 68380db4c40a2ee1156349a87254fd7b1f1a52d5, whereby the tarball's root entry is now read-only, due to the creation of "profile-directory" in the store. * tests/guix-pack.sh: Remove and recreate $test_directory before transformation option test. * tests/guix-pack-relocatable.sh: Add "chmod +w $test_directory" lines before attempts to write to it. Ludovic Courtès