From ff3f00b7f33332ebf1c3c05abc4a781684775b3c Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Tue, 14 Jul 2020 11:50:12 -0400 Subject: [PATCH] config: Drop rubocop-performance, rubocop-rspec requirements. This patch removes Rubocop extensions from Rubocop's closure to break a dependency cycle with itself. * .rubocop.yml: Remove rubocop-performance and rubocop-rspec and their corresponding directives. * .rubocop_todo.yml: Likewise. --- .rubocop.yml | 15 --------------- .rubocop_todo.yml | 44 -------------------------------------------- 2 files changed, 59 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 4f05d5be2..f12ef7c06 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -3,8 +3,6 @@ inherit_from: .rubocop_todo.yml require: - rubocop/cop/internal_affairs - - rubocop-performance - - rubocop-rspec AllCops: NewCops: enable @@ -106,16 +104,3 @@ Metrics/ClassLength: Metrics/ModuleLength: Exclude: - 'spec/**/*.rb' - -RSpec/FilePath: - Exclude: - - spec/rubocop/formatter/junit_formatter_spec.rb - -RSpec/PredicateMatcher: - EnforcedStyle: explicit - -RSpec/MessageSpies: - EnforcedStyle: receive - -RSpec/NestedGroups: - Max: 7 diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 3f72042d1..fa637cd42 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -24,47 +24,3 @@ Metrics/MethodLength: # Configuration parameters: CountComments. Metrics/ModuleLength: Max: 132 - -# Offense count: 10 -RSpec/AnyInstance: - Exclude: - - 'spec/rubocop/cli_spec.rb' - - 'spec/rubocop/cop/lint/duplicate_methods_spec.rb' - - 'spec/rubocop/cop/team_spec.rb' - - 'spec/rubocop/target_finder_spec.rb' - -# Offense count: 981 -# Configuration parameters: Prefixes. -# Prefixes: when, with, without -RSpec/ContextWording: - Enabled: false - -# Offense count: 3810 -# Configuration parameters: Max. -RSpec/ExampleLength: - Enabled: false - -# Offense count: 38 -RSpec/ExpectOutput: - Exclude: - - 'spec/rubocop/cli/cli_auto_gen_config_spec.rb' - - 'spec/rubocop/cli/cli_options_spec.rb' - - 'spec/rubocop/config_spec.rb' - - 'spec/rubocop/cop/cop_spec.rb' - - 'spec/rubocop/formatter/disabled_config_formatter_spec.rb' - - 'spec/rubocop/formatter/formatter_set_spec.rb' - - 'spec/rubocop/options_spec.rb' - - 'spec/rubocop/rake_task_spec.rb' - - 'spec/rubocop/result_cache_spec.rb' - - 'spec/rubocop/target_finder_spec.rb' - -# Offense count: 434 -RSpec/MultipleExpectations: - Max: 25 - -# Offense count: 5 -RSpec/SubjectStub: - Exclude: - - 'spec/rubocop/config_spec.rb' - - 'spec/rubocop/formatter/json_formatter_spec.rb' - - 'spec/rubocop/formatter/progress_formatter_spec.rb' -- 2.27.0 d'>maint: Reduce the package set for "i586-gnu"....* etc/release-manifest.scm (%base-packages/hurd): New variable. (%base-manifest): Use it when SYSTEM is "i586-gnu". Ludovic Courtès 2020-10-13installer: Add Emacs EXWM desktop environment....Suggested by zenny via IRC. * gnu/installer/services.scm (%system-services): Add emacs, emacs-exwm, emacs-desktop-environment. * etc/release-manifest.scm (%system-packages): Likewise. * gnu/system/examples/lightweight-desktop.tmpl: Likewise. * gnu/tests/install.scm (installation-target-desktop-os-for-gui-tests) [packages]: Likewise * gnu/installer/newt/services.scm (run-desktop-environments-cbt-page): Make one entry taller. Jan (janneke) Nieuwenhuizen 2020-04-15Merge branch 'master' into core-updatesMarius Bakke 2020-04-14maint: Ensure substitutes are available for '%default-xorg-modules'....* etc/release-manifest.scm (%system-packages): Append %DEFAULT-XORG-MODULES. Ludovic Courtès 2020-04-14maint: Actually check for the availablility of system packages....* etc/release-manifest.scm (%system-manifest): New variable. <top level>: Add it in 'concatenate-manifests' call. Ludovic Courtès 2020-04-08maint: Adjust release manifest for Guile 3.0 switch....* etc/release-manifest.scm (%packages-to-cross-build): Refer to GUILE-3.0/FIXED instead of GUILE-2.2/FIXED. Marius Bakke 2020-04-08maint: Cross-build GUILE-2.2/FIXED....* etc/release-manifest.scm (%packages-to-cross-build): Replace "guile@2.2" with GUILE-2.2/FIXED. Ludovic Courtès 2020-04-07maint: Remove GCC from the packages to cross-build....* etc/release-manifest.scm (%packages-to-cross-build): Remove GCC. Ludovic Courtès 2020-04-04maint: Remove unsupported cross-compilation jobs from 'release-manifest.scm'....* etc/release-manifest.scm (%packages-to-cross-build-for-mingw): New variable. (%cross-manifest): Use it. Remove "riscv64-linux-gnu" from %CROSS-TARGETS. Ludovic Courtès 2020-03-13maint: Add 'etc/release-manifest.scm'....* etc/release-manifest.scm: New file. * gnu/ci.scm (%cross-targets): Export. * build-aux/check-available-binaries.scm: Remove. * Makefile.am (EXTRA_DIST): Add 'etc/release-manifest.scm' and remove 'build-aux/check-available-binaries.scm'. (assert-binaries-available): Rewrite using 'guix weather -m'. Ludovic Courtès