GCC rightfully complains about redefined variables, as iterator declarations appear inside loops with a loop variable of the same name. This patch has been sent upstream. --- a/sets.cpp 2015-06-25 11:22:08.252821681 +0200 +++ b/sets.cpp 2015-06-25 11:22:23.239187985 +0200 @@ -768,11 +768,11 @@ ////////////////////////////////////////////// // Reset original missing status - vector::iterator i = PP->sample.begin(); - while ( i != PP->sample.end() ) + vector::iterator it = PP->sample.begin(); + while ( it != PP->sample.end() ) { - (*i)->missing = (*i)->flag; - ++i; + (*it)->missing = (*it)->flag; + ++it; } //////////////////////////////////////////////// --- a/elf.cpp 2009-10-10 18:00:21.000000000 +0200 +++ b/elf.cpp 2015-06-25 11:34:06.136835756 +0200 @@ -1175,10 +1175,10 @@ << setw(8) << gcnt << " " << setw(8) << (double)cnt / (double)gcnt << "\n"; - map::iterator i = chr_cnt.begin(); - while ( i != chr_cnt.end() ) + map::iterator it = chr_cnt.begin(); + while ( it != chr_cnt.end() ) { - int c = i->first; + int c = it->first; int x = chr_cnt.find( c )->second; int y = chr_gcnt.find( c )->second; @@ -1189,7 +1189,7 @@ << setw(8) << y << " " << setw(8) << (double)x / (double)y << "\n"; - ++i; + ++it; } } --- plink-1.07-src/idhelp.cpp 2009-10-10 18:00:22.000000000 +0200 +++ plink-1.07-src/idhelp.cpp.patched 2015-06-25 11:37:39.387204086 +0200 @@ -772,12 +772,12 @@ for (int j = 0 ; j < jointField.size(); j++ ) { set & jf = jointField[j]; - set::iterator j = jf.begin(); + set::iterator jit = jf.begin(); PP->printLOG(" { "); - while ( j != jf.end() ) + while ( jit != jf.end() ) { - PP->printLOG( (*j)->name + " " ); - ++j; + PP->printLOG( (*jit)->name + " " ); + ++jit; } PP->printLOG(" }"); } f='/guix/log/?id=9af6fdf861b06b7d1be9911ea19f9cb97c2689e4'>root/gnu/tests/web.scm
AgeCommit message (Expand)Author
2020-10-20services: databases: Don't specify a default postgresql version....Currently, if the postgresql package major version changes, this is going to break the service upon upgrade, because PostgreSQL will reject the data files from the differing major version of the service. Because it's important to either keep running a particular major version, or intentionally upgrade, I think the configuration would be better with no default. I think this is also going to be helpful when trying to assist users upgrading PostgreSQL. * gnu/services/databases.scm (<postgresql-configuration>): Remove default for postgresql. (postgresql-service-type): Remove the default value. * gnu/tests/databases.scm (%postgresql-os): Update accordingly. * gnu/tests/guix.scm (%guix-data-service-os): Update accordingly. * gnu/tests/monitoring.scm (%zabbix-os): Update accordingly. * gnu/tests/web.scm (patchwork-os): Update accordingly. * doc/guix.texi (PostgreSQL): Update accordingly. Christopher Baines
2020-07-13gnu: tests: Fix unbound variable....Record type descriptors were made private in a143e92446859bd1edc7a7aea85b2089c82c77da, but a usage of them was forgotten in the tests files. * gnu/tests/web.scm (patchwork-initial-database-setup-service): Use accessors to access field values instead of unexported type descriptor. Julien Lepiller
2020-04-21tests: web: Explicitly wait for the HTTP port....* gnu/tests/web.scm (run-webserver-test)["HTTP port ready"]: New test. Ludovic Courtès