See From 0507dfad5f060161f01840067e1bb1615257b636 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= Date: Mon, 8 Jun 2015 17:27:56 +0200 Subject: [PATCH] Do not rely on PATH_MAX when reading a symlink target. * src/util.c (move_file, copy_file): Use 'fromst->st_size + 1' and 'tost->st_size + 1' for the allocation, and 'fromst->st_size' and 'tost->st_size' instead of PATH_MAX. Fixes compilation on GNU/Hurd. --- src/util.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/util.c b/src/util.c index 1cc08ba..67dbd3a 100644 --- a/src/util.c +++ b/src/util.c @@ -460,12 +460,12 @@ move_file (char const *from, bool *from_needs_removal, /* FROM contains the contents of the symlink we have patched; need to convert that back into a symlink. */ - char *buffer = xmalloc (PATH_MAX); + char *buffer = xmalloc (fromst->st_size + 1); int fd, size = 0, i; if ((fd = safe_open (from, O_RDONLY | O_BINARY, 0)) < 0) pfatal ("Can't reopen file %s", quotearg (from)); - while ((i = read (fd, buffer + size, PATH_MAX - size)) > 0) + while ((i = read (fd, buffer + size, fromst->st_size - size)) > 0) size += i; if (i != 0 || close (fd) != 0) read_fatal (); @@ -610,10 +610,10 @@ copy_file (char const *from, char const *to, struct stat *tost, if (S_ISLNK (mode)) { - char *buffer = xmalloc (PATH_MAX + 1); + char *buffer = xmalloc (tost->st_size + 1); ssize_t r; - if ((r = safe_readlink (from, buffer, PATH_MAX)) < 0) + if ((r = safe_readlink (from, buffer, tost->st_size)) < 0) pfatal ("Can't read %s %s", "symbolic link", from); buffer[r] = '\0'; if (safe_symlink (buffer, to) != 0) -- 2.16.2 on value='range'>range path: root/gnu/system/examplesAgeCommit message (Expand)Author 2023-07-13services: childhurd: Bump default qemu memory to 2048MB....Janneke Nieuwenhuizen 2023-03-03services: base: Deprecate 'agetty-service' procedure....Bruno Victal 2022-12-16system: examples: Add mode prop line....Maxim Cournoyer 2022-12-12Merge branch 'version-1.4.0'Ludovic Courtès 2022-12-09system: Remove unused yggdrasil OS template....Ludovic Courtès 2022-12-04gnu: Do not use 'local-file' in Raspberry Pi OS examples....Maxim Cournoyer 2022-12-01gnu: raspberry-pi: Add a bootloader-chain for the Raspberry Pi and os examples....Stefan 2022-10-23system: Support bare-bones serial console....Tobias Geerinckx-Rice 2022-08-09maint: Use a pretty version string in ISO and VM images....Ludovic Courtès 2022-08-09system: install: Always use 'current-guix'....Ludovic Courtès 2022-01-06services: Consistently use SDDM rather than GDM on non-x86_64....Chris Marusich 2022-01-05doc: Only use GDM and GNOME on x86_64....Ricardo Wurmus 2021-12-19doc: Add group configuration example...Denis 'GNUtoo' Carikli 2021-11-23doc: Add new Swap Space section....Josselin Poiret 2021-08-29Migrate to the new 'targets' field of bootloader-configuration....Maxim Cournoyer