From: Tobias Geerinckx-Rice <me@tobias.gr>
Date: Mon, 23 Nov 2020 05:36:53 +0100
Subject: [PATCH] gnu: lsof: Make test failures fatal.

Submitted upstream[0].

[0]: https://github.com/lsof-org/lsof/pull/144

diff --git a/tests/Makefile b/tests/Makefile
index 08574a0..2923bb8 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -27,7 +27,7 @@ all:	${CKTSTDB} ${BASTST} ${STDTST} FRC
 	  exit 1 ;\
 	fi
 	@rm -f config.LT*
-	-@err=0; \
+	@err=0; \
 	echo ""; \
 	echo "Basic test:"; \
 	./${BASTST}; \
@@ -54,8 +54,11 @@ all:	${CKTSTDB} ${BASTST} ${STDTST} FRC
 	    echo "Suggestion: try the optional tests: \"make opt\""; \
 	    echo ""; \
 	  fi; \
-	fi;
-	@rm -f config.LT*
+	fi; \
+	rm -f config.LT*; \
+	if [ $$err -ne 0 ]; then \
+	  exit 1; \
+	fi
 
 auto:	ckDB silent FRC
 
@@ -112,7 +115,7 @@ LTunix: LTunix.c ${CONFIG} ${LIBOBJ} ${HDR} config.ldflags
 
 opt:	${CKTSTDB} ${OPTTST} FRC
 	@rm -f config.LT*
-	-@err=0; \
+	@err=0; \
 	echo ""; \
 	echo "Optional tests:"; \
 	for i in ${OPTTST}; do \
@@ -126,8 +129,11 @@ opt:	${CKTSTDB} ${OPTTST} FRC
 	else \
 	  echo "All optional tests succeeded."; \
 	fi; \
-	echo "";
-	@rm -f config.LT*
+	echo ""; \
+	rm -f config.LT*; \
+	if [ $$err -ne 0 ]; then \
+	  exit 1; \
+	fi
 
 optional: opt
 
m?id=d0d3c6c914777b2094dab378d11c6236dae44dc5'>tree</a><a href='/guix/commit/etc/system-tests.scm?id=d0d3c6c914777b2094dab378d11c6236dae44dc5'>commit</a><a href='/guix/diff/etc/system-tests.scm?id=d0d3c6c914777b2094dab378d11c6236dae44dc5'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/etc/system-tests.scm'>
<input type='hidden' name='id' value='d0d3c6c914777b2094dab378d11c6236dae44dc5'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=d0d3c6c914777b2094dab378d11c6236dae44dc5'>root</a>/<a href='/guix/log/etc?id=d0d3c6c914777b2094dab378d11c6236dae44dc5'>etc</a>/<a href='/guix/log/etc/system-tests.scm?id=d0d3c6c914777b2094dab378d11c6236dae44dc5'>system-tests.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/etc/system-tests.scm?id=d0d3c6c914777b2094dab378d11c6236dae44dc5&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2022-08-09 15:16:06 +0200'>2022-08-09</span></td><td><a href='/guix/commit/etc/system-tests.scm?id=5bce4c82422de6beb3ce6120ba1592be898c2b72'>build-system: Add 'channel-build-system'.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/ci.scm (channel-build-system, channel-source-&gt;package): Remove.
* gnu/packages/package-management.scm (channel-source-&gt;package): New
procedure, moved from (gnu ci).
* guix/build-system/channel.scm: New file, with code moved from (gnu ci).
* doc/guix.texi (Build Systems): Document it.
</span></span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2022-07-10 23:57:14 +0200'>2022-07-10</span></td><td><a href='/guix/commit/etc/system-tests.scm?id=9fdc4b6c283c5aa5cf10205d87fb2c58b829b9d0'>monads: Add 'mparameterize'.</a><span class='msg-avail'>...<span class='msg-tooltip'>* etc/system-tests.scm (mparameterize): Move to...
* guix/monads.scm (mparameterize): ... here.
* tests/monads.scm ("mparameterize"): New test.
* .dir-locals.el (c-mode): Add it.
</span></span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2022-04-11 00:25:33 +0200'>2022-04-11</span></td><td><a href='/guix/commit/etc/system-tests.scm?id=dbde386794cb5f4773b94a20ef585ca0f881544a'>tests: System tests really parameterize 'current-guix-package'.</a><span class='msg-avail'>...<span class='msg-tooltip'>Until now, 'current-guix-package' was parameterized in the wrong
context.  Thus, 'current-guix' would end up building a variant of the
'guix' package instead of the package returned by
'channel-source-&gt;package', which is much less expensive to build.

* etc/system-tests.scm (mparameterize): New macro.
(tests-for-current-guix): Change the 'value' field of each &lt;system-test&gt;
record to parameterize 'current-guix-package' for good.
</span></span></td><td>Ludovic Courtès</td></tr>