From: Tobias Geerinckx-Rice <me@tobias.gr>
Date: Mon, 23 Nov 2020 05:36:53 +0100
Subject: [PATCH] gnu: lsof: Make test failures fatal.

Submitted upstream[0].

[0]: https://github.com/lsof-org/lsof/pull/144

diff --git a/tests/Makefile b/tests/Makefile
index 08574a0..2923bb8 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -27,7 +27,7 @@ all:	${CKTSTDB} ${BASTST} ${STDTST} FRC
 	  exit 1 ;\
 	fi
 	@rm -f config.LT*
-	-@err=0; \
+	@err=0; \
 	echo ""; \
 	echo "Basic test:"; \
 	./${BASTST}; \
@@ -54,8 +54,11 @@ all:	${CKTSTDB} ${BASTST} ${STDTST} FRC
 	    echo "Suggestion: try the optional tests: \"make opt\""; \
 	    echo ""; \
 	  fi; \
-	fi;
-	@rm -f config.LT*
+	fi; \
+	rm -f config.LT*; \
+	if [ $$err -ne 0 ]; then \
+	  exit 1; \
+	fi
 
 auto:	ckDB silent FRC
 
@@ -112,7 +115,7 @@ LTunix: LTunix.c ${CONFIG} ${LIBOBJ} ${HDR} config.ldflags
 
 opt:	${CKTSTDB} ${OPTTST} FRC
 	@rm -f config.LT*
-	-@err=0; \
+	@err=0; \
 	echo ""; \
 	echo "Optional tests:"; \
 	for i in ${OPTTST}; do \
@@ -126,8 +129,11 @@ opt:	${CKTSTDB} ${OPTTST} FRC
 	else \
 	  echo "All optional tests succeeded."; \
 	fi; \
-	echo "";
-	@rm -f config.LT*
+	echo ""; \
+	rm -f config.LT*; \
+	if [ $$err -ne 0 ]; then \
+	  exit 1; \
+	fi
 
 optional: opt
 
href='/guix/log/gnu/packages/patches/ruby-rubocop-break-dependency-cycle.patch'>log</a><a href='/guix/tree/gnu/packages/patches/ruby-rubocop-break-dependency-cycle.patch?id=42231bc15df441d6426dec57283aca9ae7a03fcf'>tree</a><a href='/guix/commit/gnu/packages/patches/ruby-rubocop-break-dependency-cycle.patch?id=42231bc15df441d6426dec57283aca9ae7a03fcf'>commit</a><a href='/guix/diff/gnu/packages/patches/ruby-rubocop-break-dependency-cycle.patch?id=42231bc15df441d6426dec57283aca9ae7a03fcf'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/packages/patches/ruby-rubocop-break-dependency-cycle.patch'>
<input type='hidden' name='id' value='42231bc15df441d6426dec57283aca9ae7a03fcf'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=42231bc15df441d6426dec57283aca9ae7a03fcf'>root</a>/<a href='/guix/log/gnu?id=42231bc15df441d6426dec57283aca9ae7a03fcf'>gnu</a>/<a href='/guix/log/gnu/packages?id=42231bc15df441d6426dec57283aca9ae7a03fcf'>packages</a>/<a href='/guix/log/gnu/packages/patches?id=42231bc15df441d6426dec57283aca9ae7a03fcf'>patches</a>/<a href='/guix/log/gnu/packages/patches/ruby-rubocop-break-dependency-cycle.patch?id=42231bc15df441d6426dec57283aca9ae7a03fcf'>ruby-rubocop-break-dependency-cycle.patch</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/packages/patches/ruby-rubocop-break-dependency-cycle.patch?id=42231bc15df441d6426dec57283aca9ae7a03fcf&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2020-07-17 23:01:33 -0400'>2020-07-17</span></td><td><a href='/guix/commit/gnu/packages/patches/ruby-rubocop-break-dependency-cycle.patch?id=c164c402a1899ffd2b2caba541b51e05855e94b8'>gnu: ruby-rubocop: Update to 0.88.0.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/packages/patches/ruby-rubocop-break-dependency-cycle.patch: New file.
* gnu/local.mk (dist_patch_DATA): Register patch.
* gnu/packages/ruby.scm (ruby-rubocop): Update to 0.88.0.
[origin]: Use git-fetch.  Apply the newly added patch.
[arguments]: Set #:test-target to "default".  Remove #:tests?, enabling tests.
[phases]{remove-problematic-tests, disable-bundler, set-home,
make-adoc-files-writable}: New phases.  Replace the 'replace-git-ls-files
phase.
[native-inputs]: Add ruby-bump, ruby-pry, ruby-rspec, ruby-test-queue,
ruby-webmock-2 and ruby-yard.
[propagated-inputs]: Remove ruby-powerpack and ruby-jaro-winkler.  Add
ruby-regexp-parser, ruby-rexml and ruby-rubocop-ast.
</span></span></td><td>Maxim Cournoyer</td></tr>