From: Tobias Geerinckx-Rice <me@tobias.gr>
Date: Mon, 23 Nov 2020 05:36:53 +0100
Subject: [PATCH] gnu: lsof: Make test failures fatal.

Submitted upstream[0].

[0]: https://github.com/lsof-org/lsof/pull/144

diff --git a/tests/Makefile b/tests/Makefile
index 08574a0..2923bb8 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -27,7 +27,7 @@ all:	${CKTSTDB} ${BASTST} ${STDTST} FRC
 	  exit 1 ;\
 	fi
 	@rm -f config.LT*
-	-@err=0; \
+	@err=0; \
 	echo ""; \
 	echo "Basic test:"; \
 	./${BASTST}; \
@@ -54,8 +54,11 @@ all:	${CKTSTDB} ${BASTST} ${STDTST} FRC
 	    echo "Suggestion: try the optional tests: \"make opt\""; \
 	    echo ""; \
 	  fi; \
-	fi;
-	@rm -f config.LT*
+	fi; \
+	rm -f config.LT*; \
+	if [ $$err -ne 0 ]; then \
+	  exit 1; \
+	fi
 
 auto:	ckDB silent FRC
 
@@ -112,7 +115,7 @@ LTunix: LTunix.c ${CONFIG} ${LIBOBJ} ${HDR} config.ldflags
 
 opt:	${CKTSTDB} ${OPTTST} FRC
 	@rm -f config.LT*
-	-@err=0; \
+	@err=0; \
 	echo ""; \
 	echo "Optional tests:"; \
 	for i in ${OPTTST}; do \
@@ -126,8 +129,11 @@ opt:	${CKTSTDB} ${OPTTST} FRC
 	else \
 	  echo "All optional tests succeeded."; \
 	fi; \
-	echo "";
-	@rm -f config.LT*
+	echo ""; \
+	rm -f config.LT*; \
+	if [ $$err -ne 0 ]; then \
+	  exit 1; \
+	fi
 
 optional: opt
 
d.scm?id=33133a6ed32752b2ad2b974f7d63d9302c476a7f'>tree</a><a href='/guix/commit/gnu/services/hurd.scm?id=33133a6ed32752b2ad2b974f7d63d9302c476a7f'>commit</a><a href='/guix/diff/gnu/services/hurd.scm?id=33133a6ed32752b2ad2b974f7d63d9302c476a7f'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/services/hurd.scm'>
<input type='hidden' name='id' value='33133a6ed32752b2ad2b974f7d63d9302c476a7f'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=33133a6ed32752b2ad2b974f7d63d9302c476a7f'>root</a>/<a href='/guix/log/gnu?id=33133a6ed32752b2ad2b974f7d63d9302c476a7f'>gnu</a>/<a href='/guix/log/gnu/services?id=33133a6ed32752b2ad2b974f7d63d9302c476a7f'>services</a>/<a href='/guix/log/gnu/services/hurd.scm?id=33133a6ed32752b2ad2b974f7d63d9302c476a7f'>hurd.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/services/hurd.scm?id=33133a6ed32752b2ad2b974f7d63d9302c476a7f&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2020-06-13 10:04:51 +0200'>2020-06-13</span></td><td><a href='/guix/commit/gnu/services/hurd.scm?id=7304cb0a23a11b68d98ee70d911adc7048900536'>services: hurd: Remove deprecated 'hurd-getty-service' wrapper.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/services/hurd.scm (hurd-getty-service): Remove.
</span></span></td><td>Jan (janneke) Nieuwenhuizen</td></tr>
<tr><td><span title='2020-06-08 14:26:14 +0200'>2020-06-08</span></td><td><a href='/guix/commit/gnu/services/hurd.scm?id=7ccd471c71d650055e99cd02381bc8dcd86d5313'>services: Add `hurd-getty-service-type'.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/services/hurd.scm (&lt;hurd-gettty-configuration&gt;): New record.
(hurd-ttys-shepherd-service): New procedure.
(hurd-getty-service-type): New variable.
* doc/guix.texi (Hurd Services): Document it.
</span></span></td><td>Jan (janneke) Nieuwenhuizen</td></tr>
<tr><td><span title='2020-06-08 14:26:14 +0200'>2020-06-08</span></td><td><a href='/guix/commit/gnu/services/hurd.scm?id=f9c04580bf5462bb088f47ad8fc6c3136649cbd6'>services: Add `hurd-console-service-type'.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/services/hurd.scm: New file.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
* doc/guix.texi (Hurd Services): Document it.
</span></span></td><td>Jan (janneke) Nieuwenhuizen</td></tr>