From: Tobias Geerinckx-Rice <me@tobias.gr>
Date: Mon, 23 Nov 2020 05:36:53 +0100
Subject: [PATCH] gnu: lsof: Make test failures fatal.

Submitted upstream[0].

[0]: https://github.com/lsof-org/lsof/pull/144

diff --git a/tests/Makefile b/tests/Makefile
index 08574a0..2923bb8 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -27,7 +27,7 @@ all:	${CKTSTDB} ${BASTST} ${STDTST} FRC
 	  exit 1 ;\
 	fi
 	@rm -f config.LT*
-	-@err=0; \
+	@err=0; \
 	echo ""; \
 	echo "Basic test:"; \
 	./${BASTST}; \
@@ -54,8 +54,11 @@ all:	${CKTSTDB} ${BASTST} ${STDTST} FRC
 	    echo "Suggestion: try the optional tests: \"make opt\""; \
 	    echo ""; \
 	  fi; \
-	fi;
-	@rm -f config.LT*
+	fi; \
+	rm -f config.LT*; \
+	if [ $$err -ne 0 ]; then \
+	  exit 1; \
+	fi
 
 auto:	ckDB silent FRC
 
@@ -112,7 +115,7 @@ LTunix: LTunix.c ${CONFIG} ${LIBOBJ} ${HDR} config.ldflags
 
 opt:	${CKTSTDB} ${OPTTST} FRC
 	@rm -f config.LT*
-	-@err=0; \
+	@err=0; \
 	echo ""; \
 	echo "Optional tests:"; \
 	for i in ${OPTTST}; do \
@@ -126,8 +129,11 @@ opt:	${CKTSTDB} ${OPTTST} FRC
 	else \
 	  echo "All optional tests succeeded."; \
 	fi; \
-	echo "";
-	@rm -f config.LT*
+	echo ""; \
+	rm -f config.LT*; \
+	if [ $$err -ne 0 ]; then \
+	  exit 1; \
+	fi
 
 optional: opt
 
e/gnu/packages/diffoscope.scm?id=0cbc175c8bd3aecd837f1b0cd266e0deab177f40'>tree</a><a href='/guix/commit/gnu/packages/diffoscope.scm?id=0cbc175c8bd3aecd837f1b0cd266e0deab177f40'>commit</a><a href='/guix/diff/gnu/packages/diffoscope.scm?id=0cbc175c8bd3aecd837f1b0cd266e0deab177f40'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/packages/diffoscope.scm'>
<input type='hidden' name='id' value='0cbc175c8bd3aecd837f1b0cd266e0deab177f40'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=0cbc175c8bd3aecd837f1b0cd266e0deab177f40'>root</a>/<a href='/guix/log/gnu?id=0cbc175c8bd3aecd837f1b0cd266e0deab177f40'>gnu</a>/<a href='/guix/log/gnu/packages?id=0cbc175c8bd3aecd837f1b0cd266e0deab177f40'>packages</a>/<a href='/guix/log/gnu/packages/diffoscope.scm?id=0cbc175c8bd3aecd837f1b0cd266e0deab177f40'>diffoscope.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/packages/diffoscope.scm?id=0cbc175c8bd3aecd837f1b0cd266e0deab177f40&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2024-07-05 12:18:27 -0700'>2024-07-05</span></td><td><a href='/guix/commit/gnu/packages/diffoscope.scm?id=e725e47a695c82305fa65e63e54477c6a210f53d'>ugnu: diffoscope: Update to 272.</a><span class='msg-avail'>...</span></td><td>Vagrant Cascadian</td></tr>
<tr><td><span title='2024-05-31 10:18:44 -0700'>2024-05-31</span></td><td><a href='/guix/commit/gnu/packages/diffoscope.scm?id=c7888f5361fbdbe5182e7dbe90ccc12e2d95d3c3'>gnu: diffoscope: Update to 269.</a><span class='msg-avail'>...</span></td><td>Vagrant Cascadian</td></tr>
<tr><td><span title='2024-04-23 14:31:59 +0100'>2024-04-23</span></td><td><a href='/guix/commit/gnu/packages/diffoscope.scm?id=10d0e2d3110e4be2bc6cfecb9a3abb83d8e1ddd6'>gnu: diffoscope: Update to 265.</a><span class='msg-avail'>...</span></td><td>Vagrant Cascadian</td></tr>
<tr><td><span title='2024-04-23 14:31:58 +0100'>2024-04-23</span></td><td><a href='/guix/commit/gnu/packages/diffoscope.scm?id=f006dc5d74c6cc613dfab1a91e67e8e8d806f2d1'>gnu: reprotest: Update to 0.7.27.</a><span class='msg-avail'>...</span></td><td>Vagrant Cascadian</td></tr>
<tr><td><span title='2024-04-23 14:31:58 +0100'>2024-04-23</span></td><td><a href='/guix/commit/gnu/packages/diffoscope.scm?id=af969a594a2972b230caa9666fb83a2011b5d464'>gnu: diffoscope: Update to 264.</a><span class='msg-avail'>...</span></td><td>Vagrant Cascadian</td></tr>
<tr><td><span title='2024-04-15 10:08:32 +0100'>2024-04-15</span></td><td><a href='/guix/commit/gnu/packages/diffoscope.scm?id=4dec6e9fb74a688e0297b127773b88a699531785'>gnu: diffoscope: Increase test verbosity.</a><span class='msg-avail'>...</span></td><td>Vagrant Cascadian</td></tr>
<tr><td><span title='2024-04-10 13:45:40 -0700'>2024-04-10</span></td><td><a href='/guix/commit/gnu/packages/diffoscope.scm?id=c1c9d6b3cdf5955f1bf5fded2a0c496ce2e631f1'>gnu: diffoscope: Avoid skipping several tests.</a><span class='msg-avail'>...</span></td><td>Vagrant Cascadian</td></tr>
<tr><td><span title='2024-04-09 17:07:05 +0100'>2024-04-09</span></td><td><a href='/guix/commit/gnu/packages/diffoscope.scm?id=ff5ef67110b6b4cf9dd165876ed53ece5b8514a7'>gnu: diffoscope: Update to 263.</a><span class='msg-avail'>...</span></td><td>Wilko Meyer</td></tr>
<tr><td><span title='2024-03-27 12:29:39 +0000'>2024-03-27</span></td><td><a href='/guix/commit/gnu/packages/diffoscope.scm?id=62314e54d141ff0d835e8f19df71628da8c402f3'>gnu: diffoscope: Update to 261.</a><span class='msg-avail'>...</span></td><td>Vagrant Cascadian</td></tr>
<tr><td><span title='2024-03-13 12:59:41 +0000'>2024-03-13</span></td><td><a href='/guix/commit/gnu/packages/diffoscope.scm?id=199e7760f563fed3103337ce695c48f5fc889201'>gnu: diffoscope: Update to 260.</a><span class='msg-avail'>...</span></td><td>Vagrant Cascadian</td></tr>
<tr><td><span title='2024-02-27 14:42:20 -0800'>2024-02-27</span></td><td><a href='/guix/commit/gnu/packages/diffoscope.scm?id=16ab67182bc1e5b046caee9a2e38b71159703f34'>gnu: diffoscope: Update to 258.</a><span class='msg-avail'>...</span></td><td>Vagrant Cascadian</td></tr>
<tr><td><span title='2024-02-09 13:35:06 -0800'>2024-02-09</span></td><td><a href='/guix/commit/gnu/packages/diffoscope.scm?id=30196aec07dab8cc0f4a614b160f1857377a6a84'>gnu: diffoscope: Update to 256 [security fixes].</a><span class='msg-avail'>...</span></td><td>Vagrant Cascadian</td></tr>
<tr><td><span title='2024-02-02 12:03:42 -0800'>2024-02-02</span></td><td><a href='/guix/commit/gnu/packages/diffoscope.scm?id=f45d05133472a9da13eae20ba4a676c696682c90'>gnu: trydiffoscope: Update to 67.0.6.</a><span class='msg-avail'>...</span></td><td>David Pflug</td></tr>
<tr><td><span title='2024-02-02 10:31:55 -0800'>2024-02-02</span></td><td><a href='/guix/commit/gnu/packages/diffoscope.scm?id=9d52585ebd4d759607eacfef31144676b08edc81'>gnu: diffoscope: Update to 255.</a><span class='msg-avail'>...</span></td><td>David Pflug</td></tr>
<tr><td><span title='2023-12-31 11:05:38 +0800'>2023-12-31</span></td><td><a href='/guix/commit/gnu/packages/diffoscope.scm?id=111d010921fea8c803427dc316086434e748e773'>gnu: diffoscope: Update to 253.</a><span class='msg-avail'>...</span></td><td>Vagrant Cascadian</td></tr>
<tr><td><span title='2023-11-26 14:48:31 +0100'>2023-11-26</span></td><td><a href='/guix/commit/gnu/packages/diffoscope.scm?id=fbdcb31e13194c73db2b6578b2163fb194dc5002'>gnu: diffoscope: Update to 252.</a><span class='msg-avail'>...</span></td><td>Vagrant Cascadian</td></tr>