From: Tobias Geerinckx-Rice <me@tobias.gr>
Date: Mon, 23 Nov 2020 05:36:53 +0100
Subject: [PATCH] gnu: lsof: Make test failures fatal.

Submitted upstream[0].

[0]: https://github.com/lsof-org/lsof/pull/144

diff --git a/tests/Makefile b/tests/Makefile
index 08574a0..2923bb8 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -27,7 +27,7 @@ all:	${CKTSTDB} ${BASTST} ${STDTST} FRC
 	  exit 1 ;\
 	fi
 	@rm -f config.LT*
-	-@err=0; \
+	@err=0; \
 	echo ""; \
 	echo "Basic test:"; \
 	./${BASTST}; \
@@ -54,8 +54,11 @@ all:	${CKTSTDB} ${BASTST} ${STDTST} FRC
 	    echo "Suggestion: try the optional tests: \"make opt\""; \
 	    echo ""; \
 	  fi; \
-	fi;
-	@rm -f config.LT*
+	fi; \
+	rm -f config.LT*; \
+	if [ $$err -ne 0 ]; then \
+	  exit 1; \
+	fi
 
 auto:	ckDB silent FRC
 
@@ -112,7 +115,7 @@ LTunix: LTunix.c ${CONFIG} ${LIBOBJ} ${HDR} config.ldflags
 
 opt:	${CKTSTDB} ${OPTTST} FRC
 	@rm -f config.LT*
-	-@err=0; \
+	@err=0; \
 	echo ""; \
 	echo "Optional tests:"; \
 	for i in ${OPTTST}; do \
@@ -126,8 +129,11 @@ opt:	${CKTSTDB} ${OPTTST} FRC
 	else \
 	  echo "All optional tests succeeded."; \
 	fi; \
-	echo "";
-	@rm -f config.LT*
+	echo ""; \
+	rm -f config.LT*; \
+	if [ $$err -ne 0 ]; then \
+	  exit 1; \
+	fi
 
 optional: opt
 
p.scm?id=f066eebfd451ead396c5e566a81ef47892743760'>tree</a><a href='/guix/commit/gnu/tests/desktop.scm?id=f066eebfd451ead396c5e566a81ef47892743760'>commit</a><a href='/guix/diff/gnu/tests/desktop.scm?id=f066eebfd451ead396c5e566a81ef47892743760'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/tests/desktop.scm'>
<input type='hidden' name='id' value='f066eebfd451ead396c5e566a81ef47892743760'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=f066eebfd451ead396c5e566a81ef47892743760'>root</a>/<a href='/guix/log/gnu?id=f066eebfd451ead396c5e566a81ef47892743760'>gnu</a>/<a href='/guix/log/gnu/tests?id=f066eebfd451ead396c5e566a81ef47892743760'>tests</a>/<a href='/guix/log/gnu/tests/desktop.scm?id=f066eebfd451ead396c5e566a81ef47892743760'>desktop.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/tests/desktop.scm?id=f066eebfd451ead396c5e566a81ef47892743760&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2023-08-16 11:24:10 -0400'>2023-08-16</span></td><td><a href='/guix/commit/gnu/tests/desktop.scm?id=132ddca5a4fb6d789f98866b5bf85be95306c969'>gnu: elogind: Update to 252.9.</a><span class='msg-avail'>...</span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2023-05-14 23:14:25 +0200'>2023-05-14</span></td><td><a href='/guix/commit/gnu/tests/desktop.scm?id=150367c84da8766dc0358ff4878b9e17dbea6a40'>tests: elogind: Wait until 'elogind' is up.</a><span class='msg-avail'>...</span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2022-08-26 18:50:33 +0200'>2022-08-26</span></td><td><a href='/guix/commit/gnu/tests/desktop.scm?id=cac3914dfc354eb31c09958c6bc047adad682ea0'>gnu: greetd-service-type: Add supplementary groups to greeter.</a><span class='msg-avail'>...</span></td><td>muradm</td></tr>
<tr><td><span title='2022-08-26 18:48:37 +0200'>2022-08-26</span></td><td><a href='/guix/commit/gnu/tests/desktop.scm?id=d1815a68ea48b0015d1beda423d4b2879d29d9ea'>gnu: seatd-service-type: Use seat group.</a><span class='msg-avail'>...</span></td><td>muradm</td></tr>