From 52add5896661d186dec284ed646a4b33b607d2c7 Mon Sep 17 00:00:00 2001
From: Jerome Jiang <jianj@google.com>
Date: Wed, 23 May 2018 15:43:00 -0700
Subject: [PATCH] VP8: Fix use-after-free in postproc.

The pointer in vp8 postproc refers to show_frame_mi which is only
updated on show frame. However, when there is a no-show frame which also
changes the size (thus new frame buffers allocated), show_frame_mi is
not updated with new frame buffer memory.

Change the pointer in postproc to mi which is always updated.

Bug: 842265
Change-Id: I33874f2112b39f74562cba528432b5f239e6a7bd
---
 vp8/common/postproc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/vp8/common/postproc.c b/vp8/common/postproc.c
index d67ee8a57..8c292d616 100644
--- a/vp8/common/postproc.c
+++ b/vp8/common/postproc.c
@@ -65,7 +65,7 @@ void vp8_deblock(VP8_COMMON *cm, YV12_BUFFER_CONFIG *source,
   double level = 6.0e-05 * q * q * q - .0067 * q * q + .306 * q + .0065;
   int ppl = (int)(level + .5);
 
-  const MODE_INFO *mode_info_context = cm->show_frame_mi;
+  const MODE_INFO *mode_info_context = cm->mi;
   int mbr, mbc;
 
   /* The pixel thresholds are adjusted according to if or not the macroblock
-- 
2.19.0

2d63bb13c26c45a18e1d9e430fa3c5c3fadf'>tree</a><a href='/guix/commit/tests/egg.scm?id=208c2d63bb13c26c45a18e1d9e430fa3c5c3fadf'>commit</a><a href='/guix/diff/tests/egg.scm?id=208c2d63bb13c26c45a18e1d9e430fa3c5c3fadf'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/tests/egg.scm'>
<input type='hidden' name='id' value='208c2d63bb13c26c45a18e1d9e430fa3c5c3fadf'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=208c2d63bb13c26c45a18e1d9e430fa3c5c3fadf'>root</a>/<a href='/guix/log/tests?id=208c2d63bb13c26c45a18e1d9e430fa3c5c3fadf'>tests</a>/<a href='/guix/log/tests/egg.scm?id=208c2d63bb13c26c45a18e1d9e430fa3c5c3fadf'>egg.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/tests/egg.scm?id=208c2d63bb13c26c45a18e1d9e430fa3c5c3fadf&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2024-04-15 22:36:42 +0200'>2024-04-15</span></td><td><a href='/guix/commit/tests/egg.scm?id=54be7795b5cc2f6cad05f8649121372c9d5af806'>utils: Don’t re-export ‘call-with-temporary-output-file’.</a><span class='msg-avail'>...<span class='msg-tooltip'>* guix/utils.scm: Remove re-export of ‘call-with-temporary-output-file’.
Autoload a number of modules.
* guix/download.scm, guix/import/hackage.scm,
guix/import/hexpm.scm, guix/import/opam.scm,
guix/import/pypi.scm, tests/cpio.scm, tests/egg.scm,
tests/opam.scm, tests/publish.scm, tests/store-database.scm,
tests/utils.scm: Adjust imports accordingly.

Change-Id: I3f5e94631397996a30be2ea4ff8b50a3371e8ee7
</span></span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2021-11-17 23:43:14 +0100'>2021-11-17</span></td><td><a href='/guix/commit/tests/egg.scm?id=3a317f7476f8c6012e166ff9f340f861938721c9'>Merge branch 'master' into core-updates-frozen</a></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2021-11-14 00:10:58 +0100'>2021-11-14</span></td><td><a href='/guix/commit/tests/egg.scm?id=114005bea61efcd5f7d768e2d6503e873f654c16'>tests: Adjust tests/egg.scm to latest API changes.</a><span class='msg-avail'>...<span class='msg-tooltip'>This is a followup to b999c80c2e71bd4b3f26a18a321b7e7e7b580103.

* tests/egg.scm (eval-test-with-egg-file): Pass 'version' argument to
'egg-&gt;guix-package'.
</span></span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2021-07-20 23:43:29 +0200'>2021-07-20</span></td><td><a href='/guix/commit/tests/egg.scm?id=5b6285518be6e4f588f688dadf70eacf4614b797'>import: egg: Emit new-style package inputs.</a><span class='msg-avail'>...<span class='msg-tooltip'>* guix/import/egg.scm (egg-&gt;guix-package): Generate dependency list from
a list of symbols.
[egg-parse-dependency]: Return a list of symbols.
[maybe-inputs]: Wrap INPUTS in 'list' instead of 'quasiquote'.
* tests/egg.scm (match-chicken-foo): Adjust accordingly.

Signed-off-by: Ludovic Courtès &lt;ludo@gnu.org&gt;
</span></span></td><td>Sarah Morgensen</td></tr>
<tr><td><span title='2021-06-03 13:05:18 +0200'>2021-06-03</span></td><td><a href='/guix/commit/tests/egg.scm?id=bdc298ecee15283451d3aa20a849dd7bb22c8538'>import: Add CHICKEN egg importer.</a><span class='msg-avail'>...<span class='msg-tooltip'>* guix/import/egg.scm: New file.
* guix/scripts/import/egg.scm: New file.
* tests/egg.scm: New file.
* Makefile.am (MODULES, SCM_TESTS): Register them.
* po/guix/POTFILES.in: Likewise.
* guix/scripts/import.scm (importers): Add egg importer.
* doc/guix.texi (Invoking guix import, Invoking guix refresh): Document it.

Signed-off-by: Ludovic Courtès &lt;ludo@gnu.org&gt;
</span></span></td><td>Xinglu Chen</td></tr>