From d01e1bb4246323ba6fcee3b82ef1faa9b1dac82a Mon Sep 17 00:00:00 2001
From: Christian Beier <dontmind@freeshell.org>
Date: Mon, 19 Aug 2019 22:32:25 +0200
Subject: [PATCH] rfbserver: don't leak stack memory to the remote

Thanks go to Pavel Cheremushkin of Kaspersky for reporting.
---
 libvncserver/rfbserver.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libvncserver/rfbserver.c b/libvncserver/rfbserver.c
index 3bacc891..310e5487 100644
--- a/libvncserver/rfbserver.c
+++ b/libvncserver/rfbserver.c
@@ -3724,6 +3724,8 @@ rfbSendServerCutText(rfbScreenInfoPtr rfbScreen,char *str, int len)
     rfbServerCutTextMsg sct;
     rfbClientIteratorPtr iterator;
 
+    memset((char *)&sct, 0, sizeof(sct));
+
     iterator = rfbGetClientIterator(rfbScreen);
     while ((cl = rfbClientIteratorNext(iterator)) != NULL) {
         sct.type = rfbServerCutText;
submit' value='switch'/></form></td></tr>
<tr><td class='sub'>Wojtek's customized Guix</td><td class='sub right'></td></tr></table>
<table class='tabs'><tr><td>
<a href='/guix/about/'>about</a><a href='/guix/'>summary</a><a href='/guix/refs/?id=20dfda3d9ebb14b72ed33fed940ee3a1f030c99a'>refs</a><a class='active' href='/guix/log/gnu/services/hurd.scm'>log</a><a href='/guix/tree/gnu/services/hurd.scm?id=20dfda3d9ebb14b72ed33fed940ee3a1f030c99a'>tree</a><a href='/guix/commit/gnu/services/hurd.scm?id=20dfda3d9ebb14b72ed33fed940ee3a1f030c99a'>commit</a><a href='/guix/diff/gnu/services/hurd.scm?id=20dfda3d9ebb14b72ed33fed940ee3a1f030c99a'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/services/hurd.scm'>
<input type='hidden' name='id' value='20dfda3d9ebb14b72ed33fed940ee3a1f030c99a'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=20dfda3d9ebb14b72ed33fed940ee3a1f030c99a'>root</a>/<a href='/guix/log/gnu?id=20dfda3d9ebb14b72ed33fed940ee3a1f030c99a'>gnu</a>/<a href='/guix/log/gnu/services?id=20dfda3d9ebb14b72ed33fed940ee3a1f030c99a'>services</a>/<a href='/guix/log/gnu/services/hurd.scm?id=20dfda3d9ebb14b72ed33fed940ee3a1f030c99a'>hurd.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/services/hurd.scm?id=20dfda3d9ebb14b72ed33fed940ee3a1f030c99a&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2020-06-13 10:04:51 +0200'>2020-06-13</span></td><td><a href='/guix/commit/gnu/services/hurd.scm?id=7304cb0a23a11b68d98ee70d911adc7048900536'>services: hurd: Remove deprecated 'hurd-getty-service' wrapper.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/services/hurd.scm (hurd-getty-service): Remove.
</span></span></td><td>Jan (janneke) Nieuwenhuizen</td></tr>
<tr><td><span title='2020-06-08 14:26:14 +0200'>2020-06-08</span></td><td><a href='/guix/commit/gnu/services/hurd.scm?id=7ccd471c71d650055e99cd02381bc8dcd86d5313'>services: Add `hurd-getty-service-type'.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/services/hurd.scm (&lt;hurd-gettty-configuration&gt;): New record.
(hurd-ttys-shepherd-service): New procedure.
(hurd-getty-service-type): New variable.
* doc/guix.texi (Hurd Services): Document it.
</span></span></td><td>Jan (janneke) Nieuwenhuizen</td></tr>
<tr><td><span title='2020-06-08 14:26:14 +0200'>2020-06-08</span></td><td><a href='/guix/commit/gnu/services/hurd.scm?id=f9c04580bf5462bb088f47ad8fc6c3136649cbd6'>services: Add `hurd-console-service-type'.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/services/hurd.scm: New file.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
* doc/guix.texi (Hurd Services): Document it.
</span></span></td><td>Jan (janneke) Nieuwenhuizen</td></tr>