From d01e1bb4246323ba6fcee3b82ef1faa9b1dac82a Mon Sep 17 00:00:00 2001
From: Christian Beier <dontmind@freeshell.org>
Date: Mon, 19 Aug 2019 22:32:25 +0200
Subject: [PATCH] rfbserver: don't leak stack memory to the remote

Thanks go to Pavel Cheremushkin of Kaspersky for reporting.
---
 libvncserver/rfbserver.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libvncserver/rfbserver.c b/libvncserver/rfbserver.c
index 3bacc891..310e5487 100644
--- a/libvncserver/rfbserver.c
+++ b/libvncserver/rfbserver.c
@@ -3724,6 +3724,8 @@ rfbSendServerCutText(rfbScreenInfoPtr rfbScreen,char *str, int len)
     rfbServerCutTextMsg sct;
     rfbClientIteratorPtr iterator;
 
+    memset((char *)&sct, 0, sizeof(sct));
+
     iterator = rfbGetClientIterator(rfbScreen);
     while ((cl = rfbClientIteratorNext(iterator)) != NULL) {
         sct.type = rfbServerCutText;
t type='submit' value='switch'/></form></td></tr>
<tr><td class='sub'>Wojtek's customized Guix</td><td class='sub right'></td></tr></table>
<table class='tabs'><tr><td>
<a href='/guix/about/'>about</a><a href='/guix/'>summary</a><a href='/guix/refs/?id=4117a463dc477561eed3ac6903c8fd71f5cebbe4'>refs</a><a class='active' href='/guix/log/tests/gnu-maintenance.scm'>log</a><a href='/guix/tree/tests/gnu-maintenance.scm?id=4117a463dc477561eed3ac6903c8fd71f5cebbe4'>tree</a><a href='/guix/commit/tests/gnu-maintenance.scm?id=4117a463dc477561eed3ac6903c8fd71f5cebbe4'>commit</a><a href='/guix/diff/tests/gnu-maintenance.scm?id=4117a463dc477561eed3ac6903c8fd71f5cebbe4'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/tests/gnu-maintenance.scm'>
<input type='hidden' name='id' value='4117a463dc477561eed3ac6903c8fd71f5cebbe4'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=4117a463dc477561eed3ac6903c8fd71f5cebbe4'>root</a>/<a href='/guix/log/tests?id=4117a463dc477561eed3ac6903c8fd71f5cebbe4'>tests</a>/<a href='/guix/log/tests/gnu-maintenance.scm?id=4117a463dc477561eed3ac6903c8fd71f5cebbe4'>gnu-maintenance.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/tests/gnu-maintenance.scm?id=4117a463dc477561eed3ac6903c8fd71f5cebbe4&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2023-09-27 23:38:21 +0200'>2023-09-27</span></td><td><a href='/guix/commit/tests/gnu-maintenance.scm?id=72fc91b113564f8006094c0118f06af0f414d21b'>tests: ‘rewrite-url’ test no longer depends on network access.</a><span class='msg-avail'>...</span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2023-08-26 11:38:56 -0400'>2023-08-26</span></td><td><a href='/guix/commit/tests/gnu-maintenance.scm?id=1dce88777691b7a38ad66ba58b17a9b368c11e07'>gnu-maintenance: Consider Qt source tarballs as "release files".</a><span class='msg-avail'>...</span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2023-08-26 11:38:56 -0400'>2023-08-26</span></td><td><a href='/guix/commit/tests/gnu-maintenance.scm?id=6953fb924111c400a064255d8274a2caa68f7436'>gnu-maintenance: Add support to rewrite version in URL path.</a><span class='msg-avail'>...</span></td><td>Maxim Cournoyer</td></tr>
<tr><td><span title='2023-01-02 00:06:51 +0100'>2023-01-02</span></td><td><a href='/guix/commit/tests/gnu-maintenance.scm?id=d7a9d72bb02a2a3b1a99183655bf878547116032'>tests: Fix gnu-maintenance tests.</a><span class='msg-avail'>...</span></td><td>Hartmut Goebel</td></tr>