Rewrite the public symbol check to verify the shared libraries, to check for more things, and to avoid duplication; fixes make check on ARM Taken from Debian: https://salsa.debian.org/multimedia-team/mpeg2dec/blob/master/debian/patches/61_global-symbol-test.patch --- mpeg2dec.orig/test/globals +++ mpeg2dec/test/globals @@ -1,4 +1,8 @@ #!/bin/sh +# TODO +# - fix checking of .a libs; problem is that "nm -g --defined-only" lists +# internal symbols; this can be solved by using objdump, but it's probably +# good enough to just run the tests on the shared lib if test x"$srcdir" != x""; then builddir="." # running from make check, but it does not define that @@ -14,22 +18,30 @@ builddir=`cd $builddir;pwd` error=0 -bad_globals=`nm -g --defined-only $builddir/../libmpeg2/*.o |\ - awk '{if ($3) print $3}' | grep -v '^_\?mpeg2_'` - -if test x"$bad_globals" != x""; then - echo BAD GLOBAL SYMBOLS: - for s in $bad_globals; do echo $s; done +# check_bad_public_symbols [...] +# +# checks public symbols in shared libs: +# - allow prefix_anything +# - reject _prefixanything +# - allow _anything +# - reject anything else +# +# NB: skips missing files +check_bad_public_symbols() { + symbols_prefix="$1" + shift + lib_files=`ls "$@" 2>/dev/null` + [ -z "$lib_files" ] && return + bad_globals=`nm -g --defined-only $lib_files | + awk '{if ($3) print $3}' | + sed -n "/^${symbols_prefix}_/ d; /^_${symbols_prefix}/ { p; d }; /^_/ d; p"` + [ -z "$bad_globals" ] && return error=1 -fi - -bad_globals=`nm -g --defined-only $builddir/../libmpeg2/convert/*.o |\ - awk '{if ($3) print $3}' | grep -v '^_\?mpeg2convert_'` + echo BAD GLOBAL SYMBOLS in $lib_files: + echo "$bad_globals" +} -if test x"$bad_globals" != x""; then - echo BAD GLOBAL SYMBOLS: - for s in $bad_globals; do echo $s; done - error=1 -fi +check_bad_public_symbols mpeg2 $builddir/../libmpeg2/.libs/libmpeg2.so +check_bad_public_symbols mpeg2convert $builddir/../libmpeg2/convert/.libs/libmpeg2convert.so exit $error 95a31e08f9ad32b'>tests/crate.scm
AgeCommit message (Expand)Author
2024-06-03import: utils: End package descriptions with period....Herman Rimm
2024-06-03import: crate: Include a main verb in crate importer descriptions....Herman Rimm
2024-01-09guix: import: Optionally import necessary yanked crates....David Elsing
2024-01-09tests: Mock find-packages-by-name in crate importer test....David Elsing
2024-01-09import: crate: Optionally import dev-dependencies recursively....David Elsing
2023-10-22guix: import: Don't import yanked rust crates....Efraim Flashner
2022-05-30tests: Adjust crate importer test to spdx changes....Ludovic Courtès
2021-01-13tests: Fix JSON syntax error in 'crate.scm'....Ludovic Courtès
2020-12-04import: crate: Skip tests when Guile-Semver is missing....Ludovic Courtès
2020-12-02import: crate: Use existing package satisfying semver requirement....Hartmut Goebel
2020-12-02import: crate: Trim version for names after left-most non-zero part....Hartmut Goebel
2020-12-02import: utils: Trim patch version from names....Hartmut Goebel
2020-12-02import: crate: Parameterized importing of dev dependencies....Martin Becze
2020-12-02import: crate: Use guile-semver to resolve module versions....Martin Becze