Rewrite the public symbol check to verify the shared libraries, to check for
more things, and to avoid duplication; fixes make check on ARM

Taken from Debian:
https://salsa.debian.org/multimedia-team/mpeg2dec/blob/master/debian/patches/61_global-symbol-test.patch

--- mpeg2dec.orig/test/globals
+++ mpeg2dec/test/globals
@@ -1,4 +1,8 @@
 #!/bin/sh
+# TODO
+# - fix checking of .a libs; problem is that "nm -g --defined-only" lists
+#   internal symbols; this can be solved by using objdump, but it's probably
+#   good enough to just run the tests on the shared lib
 
 if test x"$srcdir" != x""; then
     builddir="."	# running from make check, but it does not define that
@@ -14,22 +18,30 @@ builddir=`cd $builddir;pwd`
 
 error=0
 
-bad_globals=`nm -g --defined-only $builddir/../libmpeg2/*.o |\
-    awk '{if ($3) print $3}' | grep -v '^_\?mpeg2_'`
-
-if test x"$bad_globals" != x""; then
-    echo BAD GLOBAL SYMBOLS:
-    for s in $bad_globals; do echo $s; done
+# check_bad_public_symbols <symbol prefix> <lib file> [<lib file>...]
+#
+# checks public symbols in shared libs:
+# - allow prefix_anything
+# - reject _prefixanything
+# - allow _anything
+# - reject anything else
+#
+# NB: skips missing files
+check_bad_public_symbols() {
+    symbols_prefix="$1"
+    shift
+    lib_files=`ls "$@" 2>/dev/null`
+    [ -z "$lib_files" ] && return
+    bad_globals=`nm -g --defined-only $lib_files |
+        awk '{if ($3) print $3}' |
+        sed -n "/^${symbols_prefix}_/ d; /^_${symbols_prefix}/ { p; d }; /^_/ d; p"`
+    [ -z "$bad_globals" ] && return
     error=1
-fi
-
-bad_globals=`nm -g --defined-only $builddir/../libmpeg2/convert/*.o |\
-    awk '{if ($3) print $3}' | grep -v '^_\?mpeg2convert_'`
+    echo BAD GLOBAL SYMBOLS in $lib_files:
+    echo "$bad_globals"
+}
 
-if test x"$bad_globals" != x""; then
-    echo BAD GLOBAL SYMBOLS:
-    for s in $bad_globals; do echo $s; done
-    error=1
-fi
+check_bad_public_symbols mpeg2 $builddir/../libmpeg2/.libs/libmpeg2.so
+check_bad_public_symbols mpeg2convert $builddir/../libmpeg2/convert/.libs/libmpeg2convert.so
 
 exit $error
192e6311f5bd78efb0a4'>root</a>/<a href='/guix/log/etc?id=53c54020f06a58a96c5e192e6311f5bd78efb0a4'>etc</a>/<a href='/guix/log/etc/disarchive-manifest.scm?id=53c54020f06a58a96c5e192e6311f5bd78efb0a4'>disarchive-manifest.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/etc/disarchive-manifest.scm?id=53c54020f06a58a96c5e192e6311f5bd78efb0a4&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2022-08-06 23:14:41 +0200'>2022-08-06</span></td><td><a href='/guix/commit/etc/disarchive-manifest.scm?id=eab5366e679c149cf0a5abeb9a196700b171d9da'>disarchive-manifest: Exclude the Chromium tarball.</a><span class='msg-avail'>...</span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2022-08-05 15:28:02 +0200'>2022-08-05</span></td><td><a href='/guix/commit/etc/disarchive-manifest.scm?id=6d4a0ccecb58c62a95f7f36fa2f4fa53dd52312e'>disarchive-manifest: Filter out origins without a hash.</a><span class='msg-avail'>...</span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2022-08-05 00:14:29 +0200'>2022-08-05</span></td><td><a href='/guix/commit/etc/disarchive-manifest.scm?id=2acffd56a58c01785ea6ea738b79991c0685d364'>disarchive-manifest: Handle tar.xz archives.</a><span class='msg-avail'>...</span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2021-10-09 01:02:18 +0200'>2021-10-09</span></td><td><a href='/guix/commit/etc/disarchive-manifest.scm?id=2ad1ef844632b7605ad6dd362e947a122a0a3925'>disarchive-manifest: Provide valid 'version' string.</a><span class='msg-avail'>...</span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2021-09-14 11:50:58 +0200'>2021-09-14</span></td><td><a href='/guix/commit/etc/disarchive-manifest.scm?id=98712c14fe3517a48603a12eb2e64db305a54fe5'>etc: Add 'disarchive-manifest.scm'.</a><span class='msg-avail'>...</span></td><td>Ludovic Courtès</td></tr>