This patch removes sources of build non-determinism in the upstream sources.

In particular, many of the compiled sources are generated with Python code,
which in turn uses dictionaries to index the output C functions.  However,
iterators over Python dictionaries have no guaranteed order, thus resulting in
the C functions being output in a random order between builds.

The patch below fixes this by forcing an order during output in several key
places.  Note, however, that future updates may uncover new such places that
just happen to be non-problematic at the time of this patch.  If you are
reading this due to finding such issues, feel free to contact me at
elaexuotee@wilsonb.com for help.

diff --git a/pysrc/ild_codegen.py b/pysrc/ild_codegen.py
index 628ec45..a9bff79 100755
--- a/pysrc/ild_codegen.py
+++ b/pysrc/ild_codegen.py
@@ -188,14 +188,14 @@ def gen_l2_func_list(agi, target_nt_dict, arg_nt_dict,
                      ild_t_member</td></tr></table>
<table class='tabs'><tr><td>
<a href='/guix/about/'>about</a><a href='/guix/'>summary</a><a href='/guix/refs/?id=38197bb50973c9e49e8ae04bb240cdbf3f057bfd'>refs</a><a href='/guix/log/CODE-OF-CONDUCT'>log</a><a href='/guix/tree/CODE-OF-CONDUCT?id=38197bb50973c9e49e8ae04bb240cdbf3f057bfd'>tree</a><a href='/guix/commit/CODE-OF-CONDUCT?id=38197bb50973c9e49e8ae04bb240cdbf3f057bfd'>commit</a><a class='active' href='/guix/diff/CODE-OF-CONDUCT?id=38197bb50973c9e49e8ae04bb240cdbf3f057bfd'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/CODE-OF-CONDUCT'>
<input type='hidden' name='id' value='38197bb50973c9e49e8ae04bb240cdbf3f057bfd'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/diff/?id=38197bb50973c9e49e8ae04bb240cdbf3f057bfd'>root</a>/<a href='/guix/diff/CODE-OF-CONDUCT?id=38197bb50973c9e49e8ae04bb240cdbf3f057bfd'>CODE-OF-CONDUCT</a></div><div class='content'><div class='cgit-panel'><b>diff options</b><form method='get'><input type='hidden' name='id' value='38197bb50973c9e49e8ae04bb240cdbf3f057bfd'/><table><tr><td colspan='2'/></tr><tr><td class='label'>context:</td><td class='ctrl'><select name='context' onchange='this.form.submit();'><option value='1'>1</option><option value='2'>2</option><option value='3' selected='selected'>3</option><option value='4'>4</option><option value='5'>5</option><option value='6'>6</option><option value='7'>7</option><option value='8'>8</option><option value='9'>9</option><option value='10'>10</option><option value='15'>15</option><option value='20'>20</option><option value='25'>25</option><option value='30'>30</option><option value='35'>35</option><option value='40'>40</option></select></td></tr><tr><td class='label'>space:</td><td class='ctrl'><select name='ignorews' onchange='this.form.submit();'><option value='0' selected='selected'>include</option><option value='1'>ignore</option></select></td></tr><tr><td class='label'>mode:</td><td class='ctrl'><select name='dt' onchange='this.form.submit();'><option value='0' selected='selected'>unified</option><option value='1'>ssdiff</option><option value='2'>stat only</option></select></td></tr><tr><td/><td class='ctrl'><noscript><input type='submit' value='reload'/></noscript></td></tr></table></form></div><div class='diffstat-header'><a href='/guix/diff/?id=38197bb50973c9e49e8ae04bb240cdbf3f057bfd'>Diffstat</a> (limited to 'CODE-OF-CONDUCT')</div><table summary='diffstat' class='diffstat'></table><div class='diffstat-summary'>0 files changed, 0 insertions, 0 deletions</div><table summary='diff' class='diff'><tr><td></td></tr></table></div> <!-- class=content -->
                         <div class=footer>generated by
                             <a href="https://git.zx2c4.com/cgit/about/">
                                 cgit
                             </a>
                         </div>
                        </div> <!-- id=cgit -->
</body>
</html>
q_arrays.items())]
+    init_f = ild_nt.gen_init_function(nt_seq_values, 
                                       'xed_ild_eosz_init')
     #dump init and lookup functions for EOSZ sequences
-    ild_nt.dump_lu_arrays(agi, list(nt_seq_arrays.values()), _eosz_c_fn,
+    ild_nt.dump_lu_arrays(agi, nt_seq_values, _eosz_c_fn,
                           mbuild.join('include-private', _eosz_header_fn),
                           init_f)
     #generate EOSZ getter functions - they get xed_decoded_inst_t*
diff --git a/pysrc/ild_imm.py b/pysrc/ild_imm.py
index 51c413c..0530bae 100755
--- a/pysrc/ild_imm.py
+++ b/pysrc/ild_imm.py
@@ -322,12 +322,14 @@ def work(agi, united_lookup, imm_nts, ild_gendir, eosz_dict,
                                      level='l3')
         nt_dict[nt_name] = array
 
+    nt_dict_values = [v for (k,v) in sorted(nt_dict.items())]
+
     #create function that calls all initialization functions for L3
-    init_f = ild_nt.gen_init_function(list(nt_dict.values()),
+    init_f = ild_nt.gen_init_function(nt_dict_values,
                                       'xed_ild_imm_l3_init')
     
     #dump L3 functions
-    ild_nt.dump_lu_arrays(agi, list(nt_dict.values()), _l3_c_fn,
+    ild_nt.dump_lu_arrays(agi, nt_dict_values, _l3_c_fn,
                           mbuild.join('include-private',_l3_header_fn),
                           init_f)