This patch fixes an issues where temporary files were created in an insecure
way.

It was first intruduced in version 3.8.3-7 and fixes
http://bugs.debian.org/438540
--- a/src/tag_file.cpp
+++ b/src/tag_file.cpp
@@ -242,8 +242,8 @@
     strcpy(sTempFile, filename.c_str());
     strcat(sTempFile, sTmpSuffix.c_str());
 
-#if ((defined(__GNUC__) && __GNUC__ >= 3  ) || !defined(HAVE_MKSTEMP))
-    // This section is for Windows folk && gcc 3.x folk
+#if !defined(HAVE_MKSTEMP)
+    // This section is for Windows folk
     fstream tmpOut;
     createFile(sTempFile, tmpOut);
 
@@ -257,7 +257,7 @@
       tmpOut.write((char *)tmpBuffer, nBytes);
     }
 
-#else //((defined(__GNUC__) && __GNUC__ >= 3  ) || !defined(HAVE_MKSTEMP))
+#else //!defined(HAVE_MKSTEMP)
 
     // else we gotta make a temp file, copy the tag into it, copy the
     // rest of the old file after the tag, delete the old file, rename
@@ -270,7 +270,7 @@
       //ID3_THROW_DESC(ID3E_NoFile, "couldn't open temp file");
     }
 
-    ofstream tmpOut(fd);
+    ofstream tmpOut(sTempFile);
     if (!tmpOut)
     {
       tmpOut.close();
@@ -285,14 +285,14 @@
     uchar tmpBuffer[BUFSIZ];
     while (file)
     {
-      file.read(tmpBuffer, BUFSIZ);
+      file.read((char *)tmpBuffer, BUFSIZ);
       size_t nBytes = file.gcount();
-      tmpOut.write(tmpBuffer, nBytes);
+      tmpOut.write((char *)tmpBuffer, nBytes);
     }
 
     close(fd); //closes the file
 
-#endif ////((defined(__GNUC__) && __GNUC__ >= 3  ) || !defined(HAVE_MKSTEMP))
+#endif ////!defined(HAVE_MKSTEMP)
 
     tmpOut.close();
     file.close();
ut type='hidden' name='id' value='ea5a5623b1211ffa4c20e686743da015fb4865f5'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=ea5a5623b1211ffa4c20e686743da015fb4865f5'>root</a>/<a href='/guix/log/gnu?id=ea5a5623b1211ffa4c20e686743da015fb4865f5'>gnu</a>/<a href='/guix/log/gnu/system?id=ea5a5623b1211ffa4c20e686743da015fb4865f5'>system</a>/<a href='/guix/log/gnu/system/pam.scm?id=ea5a5623b1211ffa4c20e686743da015fb4865f5'>pam.scm</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/system/pam.scm?id=ea5a5623b1211ffa4c20e686743da015fb4865f5&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2022-02-10 23:37:10 +0100'>2022-02-10</span></td><td><a href='/guix/commit/gnu/system/pam.scm?id=f172118ca43369af548af2d4edecb07890f917e8'>gnu: linux-pam: Change path to unix_chkpwd helper.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/packages/patches/linux-pam-unix_chkpwd.patch: New file.
* gnu/local.mk (dist_patch_DATA): Add it.
* gnu/packages/linux.scm (linux-pam): Use it.
* gnu/system/pam.scm (pam-root-service-type): Add unix_chkpwd to setuid.

Co-authored-by: Ludovic Courtès &lt;ludo@gnu.org&gt;
</span></span></td><td>Andrew Tropin</td></tr>
<tr><td><span title='2022-01-01 15:10:12 +0100'>2022-01-01</span></td><td><a href='/guix/commit/gnu/system/pam.scm?id=671e6a81804f264ddcdd6fe7579644404da079b8'>system: Allow 'chfn' to change the user's full name.</a><span class='msg-avail'>...<span class='msg-tooltip'>Fixes &lt;https://issues.guix.gnu.org/52539&gt;.
Reported by Jacob First &lt;jacob.first@member.fsf.org&gt;.

* gnu/build/accounts.scm (allocate-passwd): Add comment as to why
'real-name' is taken from PREVIOUS.  Add (not system?) to the
condition.
* gnu/system.scm (operating-system-etc-service) &lt;login.defs&gt;: Add
"CHFN_RESTRICT".
* gnu/system.scm (%setuid-programs): Add "chfn".
* gnu/system/pam.scm (base-pam-services): Add "chfn".
* doc/guix.texi (User Accounts): Document it.
</span></span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2021-08-17 01:10:25 +0300'>2021-08-17</span></td><td><a href='/guix/commit/gnu/system/pam.scm?id=b948ab8b56ac238e7a774625b8f971d28aee6055'>services: slim: Add pam-gnupg support.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/system/pam.scm (unix-pam-service): Add account and session PAM entries
for pam-gnupg.  Don't pass "#f" to "allow-root?" argument, because "lambda*"
already does this by default.
* doc/guix.texi (X Window): Document this.
* gnu/services/xorg.scm (&lt;slim-configuration&gt;)[gnupg?]: New record field.
(slim-pam-service): Pass "#:gnupg?" argument to "unix-pam-service".
</span></span></td><td>Oleg Pykhalov</td></tr>