This patch fixes an issues where temporary files were created in an insecure
way.

It was first intruduced in version 3.8.3-7 and fixes
http://bugs.debian.org/438540
--- a/src/tag_file.cpp
+++ b/src/tag_file.cpp
@@ -242,8 +242,8 @@
     strcpy(sTempFile, filename.c_str());
     strcat(sTempFile, sTmpSuffix.c_str());
 
-#if ((defined(__GNUC__) && __GNUC__ >= 3  ) || !defined(HAVE_MKSTEMP))
-    // This section is for Windows folk && gcc 3.x folk
+#if !defined(HAVE_MKSTEMP)
+    // This section is for Windows folk
     fstream tmpOut;
     createFile(sTempFile, tmpOut);
 
@@ -257,7 +257,7 @@
       tmpOut.write((char *)tmpBuffer, nBytes);
     }
 
-#else //((defined(__GNUC__) && __GNUC__ >= 3  ) || !defined(HAVE_MKSTEMP))
+#else //!defined(HAVE_MKSTEMP)
 
     // else we gotta make a temp file, copy the tag into it, copy the
     // rest of the old file after the tag, delete the old file, rename
@@ -270,7 +270,7 @@
       //ID3_THROW_DESC(ID3E_NoFile, "couldn't open temp file");
     }
 
-    ofstream tmpOut(fd);
+    ofstream tmpOut(sTempFile);
     if (!tmpOut)
     {
       tmpOut.close();
@@ -285,14 +285,14 @@
     uchar tmpBuffer[BUFSIZ];
     while (file)
     {
-      file.read(tmpBuffer, BUFSIZ);
+      file.read((char *)tmpBuffer, BUFSIZ);
       size_t nBytes = file.gcount();
-      tmpOut.write(tmpBuffer, nBytes);
+      tmpOut.write((char *)tmpBuffer, nBytes);
     }
 
     close(fd); //closes the file
 
-#endif ////((defined(__GNUC__) && __GNUC__ >= 3  ) || !defined(HAVE_MKSTEMP))
+#endif ////!defined(HAVE_MKSTEMP)
 
     tmpOut.close();
     file.close();
nu/packages/aux-files'>
<input type='hidden' name='id' value='662fd1a868ef11479030a00f5e485308c707da91'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=662fd1a868ef11479030a00f5e485308c707da91'>root</a>/<a href='/guix/log/gnu?id=662fd1a868ef11479030a00f5e485308c707da91'>gnu</a>/<a href='/guix/log/gnu/packages?id=662fd1a868ef11479030a00f5e485308c707da91'>packages</a>/<a href='/guix/log/gnu/packages/aux-files?id=662fd1a868ef11479030a00f5e485308c707da91'>aux-files</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/packages/aux-files?id=662fd1a868ef11479030a00f5e485308c707da91&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2018-09-25 23:17:20 -0400'>2018-09-25</span></td><td><a href='/guix/commit/gnu/packages/aux-files?id=fe73352e8073ea0a0e6f6b5591f24395671998ab'>gnu: linux-libre: Enable SHPC PCI Hotplug driver, now built-in only.</a><span class='msg-avail'>...</span></td><td>Mark H Weaver</td></tr>
<tr><td><span title='2018-08-18 06:19:31 -0400'>2018-08-18</span></td><td><a href='/guix/commit/gnu/packages/aux-files?id=3004f1c69b258837b0e49a567787c97479ce6e71'>gnu: linux-libre: Update to 4.18.1.</a><span class='msg-avail'>...</span></td><td>Mark H Weaver</td></tr>
<tr><td><span title='2018-07-04 19:30:06 -0400'>2018-07-04</span></td><td><a href='/guix/commit/gnu/packages/aux-files?id=cc78392923e534f181ef451c177c607b32349213'>gnu: Remove linux-libre@4.1.</a><span class='msg-avail'>...</span></td><td>Mark H Weaver</td></tr>
<tr><td><span title='2018-06-05 17:21:03 -0400'>2018-06-05</span></td><td><a href='/guix/commit/gnu/packages/aux-files?id=db89d31876d2f02da1e550813b3e34d9cd605633'>gnu: linux-libre: Update to 4.17.</a><span class='msg-avail'>...</span></td><td>Mark H Weaver</td></tr>
<tr><td><span title='2018-05-21 00:12:02 +0200'>2018-05-21</span></td><td><a href='/guix/commit/gnu/packages/aux-files?id=5a9dc4a8074cde2fec3ecc7ea71f2e976c8c38c0'>gnu: linux-libre: Enable build for aarch64-linux.</a><span class='msg-avail'>...</span></td><td>Vagrant Cascadian</td></tr>
<tr><td><span title='2018-05-11 18:42:42 +0200'>2018-05-11</span></td><td><a href='/guix/commit/gnu/packages/aux-files?id=30da3173d5ee69777d0e1de4f9c977dea72e8a77'>pack: Relocatable wrapper now properly maps the current UID/GID.</a><span class='msg-avail'>...</span></td><td>Ludovic Courtès</td></tr>
<tr><td><span title='2018-05-10 14:53:57 +0200'>2018-05-10</span></td><td><a href='/guix/commit/gnu/packages/aux-files?id=47a60325ca650e8fc1a291c8655b4297f4de8deb'>pack: Add '--relocatable'.</a><span class='msg-avail'>...</span></td><td>Ludovic Courtès</td></tr>