This patch fixes an issues where temporary files were created in an insecure
way.

It was first intruduced in version 3.8.3-7 and fixes
http://bugs.debian.org/438540
--- a/src/tag_file.cpp
+++ b/src/tag_file.cpp
@@ -242,8 +242,8 @@
     strcpy(sTempFile, filename.c_str());
     strcat(sTempFile, sTmpSuffix.c_str());
 
-#if ((defined(__GNUC__) && __GNUC__ >= 3  ) || !defined(HAVE_MKSTEMP))
-    // This section is for Windows folk && gcc 3.x folk
+#if !defined(HAVE_MKSTEMP)
+    // This section is for Windows folk
     fstream tmpOut;
     createFile(sTempFile, tmpOut);
 
@@ -257,7 +257,7 @@
       tmpOut.write((char *)tmpBuffer, nBytes);
     }
 
-#else //((defined(__GNUC__) && __GNUC__ >= 3  ) || !defined(HAVE_MKSTEMP))
+#else //!defined(HAVE_MKSTEMP)
 
     // else we gotta make a temp file, copy the tag into it, copy the
     // rest of the old file after the tag, delete the old file, rename
@@ -270,7 +270,7 @@
       //ID3_THROW_DESC(ID3E_NoFile, "couldn't open temp file");
     }
 
-    ofstream tmpOut(fd);
+    ofstream tmpOut(sTempFile);
     if (!tmpOut)
     {
       tmpOut.close();
@@ -285,14 +285,14 @@
     uchar tmpBuffer[BUFSIZ];
     while (file)
     {
-      file.read(tmpBuffer, BUFSIZ);
+      file.read((char *)tmpBuffer, BUFSIZ);
       size_t nBytes = file.gcount();
-      tmpOut.write(tmpBuffer, nBytes);
+      tmpOut.write((char *)tmpBuffer, nBytes);
     }
 
     close(fd); //closes the file
 
-#endif ////((defined(__GNUC__) && __GNUC__ >= 3  ) || !defined(HAVE_MKSTEMP))
+#endif ////!defined(HAVE_MKSTEMP)
 
     tmpOut.close();
     file.close();
ackages/patches/xnnpack-system-libraries.patch?id=1bd44b425b79e9da160b33a9b19d01973b44772e'>diff</a></td><td class='form'><form class='right' method='get' action='/guix/log/gnu/packages/patches/xnnpack-system-libraries.patch'>
<input type='hidden' name='id' value='1bd44b425b79e9da160b33a9b19d01973b44772e'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/guix/log/?id=1bd44b425b79e9da160b33a9b19d01973b44772e'>root</a>/<a href='/guix/log/gnu?id=1bd44b425b79e9da160b33a9b19d01973b44772e'>gnu</a>/<a href='/guix/log/gnu/packages?id=1bd44b425b79e9da160b33a9b19d01973b44772e'>packages</a>/<a href='/guix/log/gnu/packages/patches?id=1bd44b425b79e9da160b33a9b19d01973b44772e'>patches</a>/<a href='/guix/log/gnu/packages/patches/xnnpack-system-libraries.patch?id=1bd44b425b79e9da160b33a9b19d01973b44772e'>xnnpack-system-libraries.patch</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/guix/log/gnu/packages/patches/xnnpack-system-libraries.patch?id=1bd44b425b79e9da160b33a9b19d01973b44772e&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2022-07-07 14:02:33 +0200'>2022-07-07</span></td><td><a href='/guix/commit/gnu/packages/patches/xnnpack-system-libraries.patch?id=87b43ab56214a4fee33814117212df6cfc64f5c0'>gnu: xnnpack: Update to 0.0-2.ae108ef.</a><span class='msg-avail'>...<span class='msg-tooltip'>* gnu/packages/machine-learning.scm (xnnpack): Update to 0.0-2.ae108ef.
* gnu/packages/patches/xnnpack-system-libraries.patch: Update.
</span></span></td><td>Ricardo Wurmus</td></tr>
cessary "caffe2/onnx/backend.cc"
substitution.
[arguments]: Add 'remove-caffe2-onnx-scripts' phase.
* gnu/packages/patches/python-pytorch-runpath.patch,
gnu/packages/patches/python-pytorch-system-libraries.patch: Update.
</span></span></td><td>Ludovic Courtès</td></tr>